Repository navigation
Add update-skill --hook for automatic agent-toolkit skill updates - #10797
Merged
luigi617 merged 9 commits intoNov 11, 2026
Merged
Conversation
luigi617
force-pushed
the
automatic-skill-update-command
branch
2 times, most recently
from
October 22, 2026 17:20
76ca45c to
e3e93d0
Compare
luigi617
marked this pull request as ready for review
October 22, 2026 17:50
luigi617
force-pushed
the
automatic-skill-update-command
branch
from
November 3, 2026 21:18
abdb544 to
3ca581a
Compare
Base automatically changed from
automatic-skill-update-safe-update
to
feat-automatic-skill-update
November 5, 2026 19:09
luigi617
force-pushed
the
automatic-skill-update-command
branch
from
November 5, 2026 19:10
3ca581a to
436fcaf
Compare
AndrewAsseily
requested changes
Nov 5, 2026
AndrewAsseily
left a comment
AndrewAsseily
left a comment
Contributor
There was a problem hiding this comment.
Couldn't find where some of these numbers come from
- update_skill.py (https://github.com/aws/aws-cli/blob/3ca581acc/awscli/customizations/agenttoolkit/update_skill.py#L139)
- update_skill.py (https://github.com/aws/aws-cli/blob/3ca581acc/awscli/customizations/agenttoolkit/update_skill.py#L147)
- update_skill.py (https://github.com/aws/aws-cli/blob/3ca581acc/awscli/customizations/agenttoolkit/update_skill.py#L152)
- update_skill.py (https://github.com/aws/aws-cli/blob/3ca581acc/awscli/customizations/agenttoolkit/update_skill.py#L153)
- filelock.py (https://github.com/aws/aws-cli/blob/4b4409469/awscli/customizations/agenttoolkit/filelock.py#L19-L20)
- atomic.py (https://github.com/aws/aws-cli/blob/4b4409469/awscli/customizations/agenttoolkit/atomic.py#L23-L24)
| # Agents stop a hook after 60 seconds and report it as an error. A failed | ||
| # check is tried again after HOOK_RETRY_INTERVAL, so fail fast instead of | ||
| # retrying. | ||
| HOOK_CLIENT_CONFIG = Config( |
Contributor
There was a problem hiding this comment.
All the agent toolkit operations are noAuth but since this config doesn't set signature_version, botocore still loads credentials when it creates the client and so if the default profile's aws login session has expired every hook run fails. Could we add signature_version=UNSIGNED?
luigi617
force-pushed
the
automatic-skill-update-command
branch
from
November 5, 2026 20:28
436fcaf to
a02e194
Compare
added 8 commits
November 6, 2026 14:36
Runs as an agent's session start hook: updates installed AWS skills, installs new aws-core skills into agents that already have AWS skills, prints what the agent expects, records the run and always succeeds. Hook runs take turns and skip a run right after another for the same agent. Installing the hooks into agent configs comes separately.
Record hook runs by agent id instead of the path of the agent's hook file, so this command does not need to know where hooks are installed. Removes hook_config_path and is_hook_supported from hooks.py, leaving the agent ids and the output formatting the hook run uses.
Reverts 00c606b. last_hook_run stays keyed by the path of the agent's hook config, as defined in automatic-skill-update-safe-update, so separate config directories of one agent keep separate records. hook_config_path only locates that file; it does not install or manage hooks.
luigi617
force-pushed
the
automatic-skill-update-command
branch
from
November 6, 2026 19:37
a02e194 to
7fbe912
Compare
AndrewAsseily
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds a
--hookflag toaws agent-toolkit update-skill, for an agent's session start hook to keep AWS skills up to date automatically. Installed hooks runupdate-skill --hook --agent <agent>, so each hook only updates its own agent's skills. Installing the hooks into agent configs comes in a follow-up PR.When automatic updates are turned on, a hook run:
--agent, or in every detected agent when--agentisn't set (the same asupdate-skill --all).aws-coreskills into skills directories that already have toolkit-installed skills. Directories the toolkit didn't create are left alone.state.jsonby real path, so agents sharing a directory share one check.--agentagent expects (Claude Code, Gemini CLI, Codex, Cursor, Kiro), as plain text for other agents or without--agent, and nothing if nothing changed.--hookimplies--alland can't be combined with--skill-name. An invalid--agentgives the same error asupdate-skillbefore the run starts.Other changes:
GEMINI_CLI_HOMEwhen it's set.Intentional design:
remove-skillis installed again at the next check.Testing:
GEMINI_CLI_HOMEpaths.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.