Repository navigation
Improve error message for duplicate profile sections in config - #10885
Open
KushagraIndurkhya wants to merge 1 commit into
Open
KushagraIndurkhya wants to merge 1 commit into
KushagraIndurkhya wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: #9261
Description of changes
When
~/.aws/configcontains duplicated profile sections, the parser caughtconfigparser.DuplicateSectionErrorand re-raised a genericConfigParseError(path=path)producingUnable to parse config file: <path>without indicating which profile was duplicated, the line numbers, or what went wrong.This change:
ConfigParseErrorto accept an optionalmessagestring rendered as:Unable to parse config file: <path> - <message>(preserving backwards compatibility and pickle roundtripping).raw_config_parseto catchconfigparser.DuplicateSectionError, determine the duplicated section/profile name, and locate line numbers for both the first occurrence and the duplicate occurrence:Found duplicate profile 'xyz' (first seen on line 5, duplicated on line 20)tests/unit/botocore/test_configloader.pycovering standard profiles, quoted profiles, default profile, and non-profile sections.tests/unit/botocore/test_exceptions.pyverifying message formatting and pickle roundtrip compatibility..changes/next-release/config-duplicate-profile-error.json.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.