Repository navigation
Handle UTF-8 BOM in config and credentials files - #10886
Open
KushagraIndurkhya wants to merge 1 commit into
Open
KushagraIndurkhya wants to merge 1 commit into
KushagraIndurkhya wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: #10768
Description of changes
When config or credentials files are saved with a UTF-8 Byte Order Mark (BOM:
\xef\xbb\xbf, common on Windows editors such as Notepad), running CLI commands failed withUnable to parse config filebecause the first section header was parsed as\ufeff[section]instead of[section].This change:
encoding='utf-8-sig'tocp.read([path], encoding='utf-8-sig')inraw_config_parse()inawscli/botocore/configloader.py. Theutf-8-sigPython codec transparently strips the BOM marker if present while behaving identically to standard UTF-8 when absent.raw_config_parse.tests/unit/botocore/test_configloader.pycovering single config files, nested configs, multi-file loads with BOM, and credentials file BOM handling intests/unit/botocore/test_credentials.py..changes/next-release/config-utf8-bom.json.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.