Repository navigation
Release finished CRT transfers instead of keeping them until shutdown - #10888
Merged
Merged
Conversation
hssyoo
marked this pull request as ready for review
November 12, 2026 15:44
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10880
Recursive CRT transfers create a coordinator object for each file and appends to a list without ever getting cleaned up, even after the transfer completes (success or failure). This causes a memory leak that grows with each file transferred.
This PR fixes the leak by removing the coordinator upon completion and the CRT request, which holds a reference to its coordinator.