Repository navigation
Conversation
When a caller passes expected_state to AuthCodeFetcher.get_auth_code_and_state, OAuthCallbackHandler only ends the wait on a GET /oauth/callback whose state matches (constant time compare). Other paths get 404, a missing or wrong state gets 400, and the wait continues. Each connection gets _REQUEST_TIMEOUT, and the authorization server's error and error_description are kept in AuthCodeFetcher.error. aws sso login and aws login now pass their state. The server also logs handler errors, such as a browser disconnecting early, at debug instead of printing a traceback.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
expected_statetoAuthCodeFetcher.get_auth_code_and_state,OAuthCallbackHandleronly ends the wait on aGET /oauth/callbackwhose state matches (constant time compare). Other paths get 404; a missing or wrong state gets 400, and the wait continues.Description of tests:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.