Skip to content

fix(ci): grant AI review contents write permission #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhongkechen merged 1 commit into from
Aug 31, 2026
+21 −1
Merged

fix(ci): grant AI review contents write permission #695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/scripts/tests/test_ai_pr_review_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
from pathlib import Path


WORKFLOW_PATH = Path(__file__).parents[2] / "workflows" / "ai-pr-review.yml"


def test_ai_pr_review_caller_grants_reusable_workflow_permissions() -> None:
workflow = WORKFLOW_PATH.read_text()

required_permissions = (
" ai-pr-review:\n"
" permissions:\n"
" contents: write\n"
" id-token: write\n"
" pull-requests: write\n"
)
assert required_permissions in workflow
2 changes: 1 addition & 1 deletion .github/workflows/ai-pr-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ permissions: {}
jobs:
ai-pr-review:
permissions:
contents: read
contents: write
id-token: write
pull-requests: write
uses: aws/aws-durable-execution-ci/.github/workflows/ai-pr-review.yml@8de63fa646c1b7b778829126cf53b7874074795e
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/test-parser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
- '.github/scripts/check_otel_wheel_dependencies.py'
- '.github/scripts/parse_sdk_branch.py'
- '.github/scripts/tests/**'
- '.github/workflows/ai-pr-review.yml'
- '.github/workflows/opentelemetry-conformance-tests.yml'
- 'packages/aws-durable-execution-sdk-python-otel/pyproject.toml'
push:
Expand All @@ -16,6 +17,7 @@ on:
- '.github/scripts/check_otel_wheel_dependencies.py'
- '.github/scripts/parse_sdk_branch.py'
- '.github/scripts/tests/**'
- '.github/workflows/ai-pr-review.yml'
- '.github/workflows/opentelemetry-conformance-tests.yml'
- 'packages/aws-durable-execution-sdk-python-otel/pyproject.toml'

Expand All @@ -34,6 +36,7 @@ jobs:
- name: Run script tests
run: |
python -m pytest \
.github/scripts/tests/test_ai_pr_review_workflow.py \
.github/scripts/tests/test_build_lambda_layer.py \
.github/scripts/tests/test_check_otel_wheel_dependencies.py \
.github/scripts/tests/test_opentelemetry_conformance_workflow.py \
Expand Down