Skip to content

test: add replay identity conformance case - #701

Open
zhongkechen wants to merge 16 commits into
mainfrom
test/conformance-general-11-1
Open

test: add replay identity conformance case#701
zhongkechen wants to merge 16 commits into
mainfrom
test/conformance-general-11-1

Conversation

@zhongkechen

Copy link
Copy Markdown
Contributor

Summary

  • add the general conformance suite and handler for requirement 11-1
  • emit a named WAIT on the first invocation and a named STEP at the same replay position
  • enable replay-visible canary logging and prove the mismatched step body never executes
  • make replay-identity diagnostics identify checkpointed values as expected and emitted values as current

Dependencies

Testing

  • python3 packages/aws-durable-execution-sdk-python-conformance-tests/scripts/discover_suites.py
  • python3 packages/aws-durable-execution-sdk-python-conformance-tests/scripts/build_examples.py
  • focused state tests: 4 passed
  • focused execution tests: 3 passed
  • hatch run dev-core:typecheck
  • Ruff check and format verification for changed Python files
  • git diff --check

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime September 1, 2026 21:27 — with GitHub Actions Inactive
@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime September 1, 2026 21:43 — with GitHub Actions Inactive
@github-actions

This comment has been minimized.

…mplate_general.yaml

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime September 3, 2026 19:01 — with GitHub Actions Inactive

@durable_step
def unexpected_step(step_context: StepContext) -> str:
step_context.logger.info("DETERMINISM_STEP_BODY_EXECUTED")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex AI review · Finding arf_v1_qk6nurjxyn6fmk3nrrncxxiaaq

[P2] Make the step-body canary replay-visible

The step inherits the replaying context's logger, so this INFO call is suppressed. If a regression executes unexpected_step before rejecting the identity mismatch, the canary remains absent and requirement 11-1 cannot detect that forbidden execution. Cast step_context.logger to the concrete Logger and emit through with_is_replaying(lambda: False) so the step metadata is preserved while the canary remains visible.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Codex AI review

One actionable issue remains in the new conformance case: its forbidden-body canary is not observable during replay. No other issues found.

Reviewed commit 529310cf7ba0d3aa69b81adef13730ebb14ad047. Workflow run

Base automatically changed from fix/replay-operation-identity to main September 3, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant