test: add replay identity conformance case - #701
Conversation
This comment has been minimized.
This comment has been minimized.
…mplate_general.yaml Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
||
| @durable_step | ||
| def unexpected_step(step_context: StepContext) -> str: | ||
| step_context.logger.info("DETERMINISM_STEP_BODY_EXECUTED") |
There was a problem hiding this comment.
Codex AI review · Finding arf_v1_qk6nurjxyn6fmk3nrrncxxiaaq
[P2] Make the step-body canary replay-visible
The step inherits the replaying context's logger, so this INFO call is suppressed. If a regression executes unexpected_step before rejecting the identity mismatch, the canary remains absent and requirement 11-1 cannot detect that forbidden execution. Cast step_context.logger to the concrete Logger and emit through with_is_replaying(lambda: False) so the step metadata is preserved while the canary remains visible.
Codex AI reviewOne actionable issue remains in the new conformance case: its forbidden-body canary is not observable during replay. No other issues found. Reviewed commit |
Summary
generalconformance suite and handler for requirement11-1WAITon the first invocation and a namedSTEPat the same replay positionDependencies
Testing
python3 packages/aws-durable-execution-sdk-python-conformance-tests/scripts/discover_suites.pypython3 packages/aws-durable-execution-sdk-python-conformance-tests/scripts/build_examples.pyhatch run dev-core:typecheckgit diff --checkBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.