Skip to content

docs(insight): fix scheduler comment - #705

Closed
wangyb-A wants to merge 1 commit into
feat/insight-async-exportfrom
docs/insight-scheduler-comment
Closed

docs(insight): fix scheduler comment#705
wangyb-A wants to merge 1 commit into
feat/insight-async-exportfrom
docs/insight-scheduler-comment

Conversation

@wangyb-A

@wangyb-A wangyb-A commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix the stale _emit method reference in a Workflow Insight comment after the method was split into _build_record and _schedule_record.

Stacked on #702.

Comment audit

  • Timed-out barrier accumulation: fixed in 6c723ba; thread is outdated.
  • Implicit RLock: fixed in 6c723ba; thread resolved.
  • Duplicate exporter instance: fixed in 7ba7520; thread resolved.
  • Unlocked scheduled flag: fixed in 7ba7520; thread resolved.
  • Latest Codex review: no actionable findings.
  • Latest Claude review: only this documentation nit remained.

Validation

  • Insight package Ruff lint and format passed.
  • Commit lint passed.
  • Source behavior is unchanged; no tests or conformance rerun needed.

@wangyb-A

wangyb-A commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Applied directly to #702 as commit 9e0e717; closing this stacked PR as superseded.

@wangyb-A wangyb-A closed this Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant