Skip to content

fix operations with optional auth #3932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbiscigl merged 1 commit into from
Sep 22, 2026
Merged

fix operations with optional auth #3932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changelog/bugfix-fix-noauth.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"type": "bugfix",
"category": "aws-cpp-sdk-core",
"contributor": "sbiscigl",
"description": "fix noauth in operations that support it"
}
1 change: 1 addition & 0 deletions cmake/sdksCommon.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ list(APPEND SDK_TEST_PROJECT_LIST "timestream-query:tests/aws-cpp-sdk-timestream
list(APPEND SDK_TEST_PROJECT_LIST "transcribestreaming:tests/aws-cpp-sdk-transcribestreaming-integ-tests")
list(APPEND SDK_TEST_PROJECT_LIST "eventbridge:tests/aws-cpp-sdk-eventbridge-tests")
list(APPEND SDK_TEST_PROJECT_LIST "dsql:tests/aws-cpp-sdk-dsql-unit-tests")
list(APPEND SDK_TEST_PROJECT_LIST "sso-oidc:tests/aws-cpp-sdk-sso-oidc-unit-tests")
list(APPEND SDK_TEST_PROJECT_LIST "bedrock-runtime:tests/aws-cpp-sdk-bedrock-runtime-integration-tests")


Expand Down
2 changes: 1 addition & 1 deletion generated/src/aws-cpp-sdk-codecatalyst/include/aws/codecatalyst/CodeCatalystClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1179,7 +1179,7 @@ class AWS_CODECATALYST_API CodeCatalystClient : public Aws::Client::AWSJsonClien

InvokeOperationOutcome InvokeServiceOperation(const AmazonWebServiceRequest& request,
const std::function<void(Aws::Endpoint::ResolveEndpointOutcome&)>& resolveUri,
Aws::Http::HttpMethod httpMethod) const;
Aws::Http::HttpMethod httpMethod, const char* signerName = Aws::Auth::SIGV4_SIGNER) const;

CodeCatalystClientConfiguration m_clientConfiguration;
std::shared_ptr<CodeCatalystEndpointProviderBase> m_endpointProvider;
Expand Down
80 changes: 40 additions & 40 deletions generated/src/aws-cpp-sdk-codecatalyst/source/CodeCatalystClient.cpp
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion ...ted/src/aws-cpp-sdk-cognito-identity/include/aws/cognito-identity/CognitoIdentityClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,7 +824,8 @@ class AWS_COGNITOIDENTITY_API CognitoIdentityClient : public Aws::Client::AWSJso

typedef Aws::Utils::Outcome<Aws::AmazonWebServiceResult<RESPONSE>, CognitoIdentityError> InvokeOperationOutcome;

InvokeOperationOutcome InvokeServiceOperation(const AmazonWebServiceRequest& request, Aws::Http::HttpMethod httpMethod) const;
InvokeOperationOutcome InvokeServiceOperation(const AmazonWebServiceRequest& request, Aws::Http::HttpMethod httpMethod,
const char* signerName = Aws::Auth::SIGV4_SIGNER) const;

CognitoIdentityClientConfiguration m_clientConfiguration;
std::shared_ptr<CognitoIdentityEndpointProviderBase> m_endpointProvider;
Expand Down
13 changes: 7 additions & 6 deletions generated/src/aws-cpp-sdk-cognito-identity/source/CognitoIdentityClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,8 @@ void CognitoIdentityClient::OverrideEndpoint(const Aws::String& endpoint) {
m_endpointProvider->OverrideEndpoint(endpoint);
}
CognitoIdentityClient::InvokeOperationOutcome CognitoIdentityClient::InvokeServiceOperation(const AmazonWebServiceRequest& request,
Aws::Http::HttpMethod httpMethod) const {
Aws::Http::HttpMethod httpMethod,
const char* signerName) const {
auto operationName = request.GetServiceRequestName();
auto serviceName = GetServiceClientName();

Expand Down Expand Up @@ -192,7 +193,7 @@ CognitoIdentityClient::InvokeOperationOutcome CognitoIdentityClient::InvokeServi
AWS_OPERATION_CHECK_SUCCESS_DYNAMIC(endpointResolutionOutcome, operationName, CoreErrors, CoreErrors::ENDPOINT_RESOLUTION_FAILURE,
endpointResolutionOutcome.GetError().GetMessage());

return InvokeOperationOutcome{MakeRequest(request, endpointResolutionOutcome.GetResult(), httpMethod, Aws::Auth::SIGV4_SIGNER)};
return InvokeOperationOutcome{MakeRequest(request, endpointResolutionOutcome.GetResult(), httpMethod, signerName)};
},
TracingUtils::SMITHY_CLIENT_DURATION_METRIC, *meter,
{{TracingUtils::SMITHY_METHOD_DIMENSION, operationName}, {TracingUtils::SMITHY_SERVICE_DIMENSION, serviceName}});
Expand Down Expand Up @@ -229,13 +230,13 @@ DescribeIdentityPoolOutcome CognitoIdentityClient::DescribeIdentityPool(const De
}

GetCredentialsForIdentityOutcome CognitoIdentityClient::GetCredentialsForIdentity(const GetCredentialsForIdentityRequest& request) const {
auto result = InvokeServiceOperation(request, Aws::Http::HttpMethod::HTTP_POST);
auto result = InvokeServiceOperation(request, Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::NULL_SIGNER);
return result.IsSuccess() ? GetCredentialsForIdentityOutcome(result.GetResultWithOwnership())
: GetCredentialsForIdentityOutcome(std::move(result.GetError()));
}

GetIdOutcome CognitoIdentityClient::GetId(const GetIdRequest& request) const {
auto result = InvokeServiceOperation(request, Aws::Http::HttpMethod::HTTP_POST);
auto result = InvokeServiceOperation(request, Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::NULL_SIGNER);
return result.IsSuccess() ? GetIdOutcome(result.GetResultWithOwnership()) : GetIdOutcome(std::move(result.GetError()));
}

Expand All @@ -246,7 +247,7 @@ GetIdentityPoolRolesOutcome CognitoIdentityClient::GetIdentityPoolRoles(const Ge
}

GetOpenIdTokenOutcome CognitoIdentityClient::GetOpenIdToken(const GetOpenIdTokenRequest& request) const {
auto result = InvokeServiceOperation(request, Aws::Http::HttpMethod::HTTP_POST);
auto result = InvokeServiceOperation(request, Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::NULL_SIGNER);
return result.IsSuccess() ? GetOpenIdTokenOutcome(result.GetResultWithOwnership()) : GetOpenIdTokenOutcome(std::move(result.GetError()));
}

Expand Down Expand Up @@ -318,7 +319,7 @@ UnlinkDeveloperIdentityOutcome CognitoIdentityClient::UnlinkDeveloperIdentity(co
}

UnlinkIdentityOutcome CognitoIdentityClient::UnlinkIdentity(const UnlinkIdentityRequest& request) const {
auto result = InvokeServiceOperation(request, Aws::Http::HttpMethod::HTTP_POST);
auto result = InvokeServiceOperation(request, Aws::Http::HttpMethod::HTTP_POST, Aws::Auth::NULL_SIGNER);
return result.IsSuccess() ? UnlinkIdentityOutcome(result.GetResultWithOwnership()) : UnlinkIdentityOutcome(std::move(result.GetError()));
}

Expand Down
3 changes: 2 additions & 1 deletion ...rated/src/aws-cpp-sdk-cognito-idp/include/aws/cognito-idp/CognitoIdentityProviderClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5509,7 +5509,8 @@ class AWS_COGNITOIDENTITYPROVIDER_API CognitoIdentityProviderClient

typedef Aws::Utils::Outcome<Aws::AmazonWebServiceResult<RESPONSE>, CognitoIdentityProviderError> InvokeOperationOutcome;

InvokeOperationOutcome InvokeServiceOperation(const AmazonWebServiceRequest& request, Aws::Http::HttpMethod httpMethod) const;
InvokeOperationOutcome InvokeServiceOperation(const AmazonWebServiceRequest& request, Aws::Http::HttpMethod httpMethod,
const char* signerName = Aws::Auth::SIGV4_SIGNER) const;

CognitoIdentityProviderClientConfiguration m_clientConfiguration;
std::shared_ptr<CognitoIdentityProviderEndpointProviderBase> m_endpointProvider;
Expand Down
Loading
Loading