fix static linking on windows - #3936
Merged
Merged
Conversation
sbiscigl
marked this pull request as ready for review
September 22, 2026 14:47
sbaluja
approved these changes
Sep 22, 2026
pulimsr
approved these changes
Sep 22, 2026
sbiscigl
force-pushed
the
fix-static-windows
branch
5 times, most recently
from
September 23, 2026 13:11
1b3f486 to
7c08476
Compare
sbiscigl
force-pushed
the
fix-static-windows
branch
from
September 23, 2026 14:28
7c08476 to
c0911cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3935
Description of changes:
fixing a bug where a new macro
SMITHY_TEMPLATE_EXPORTwas introduced instead of usingSMITHY_APIto correctly handle windows export semanticsCheck all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.