[DO NOT MERGE] PR to test PHPCS workflow formatter - #3351
lukasdchang wants to merge 18 commits into
Conversation
stobrien89
left a comment
stobrien89
left a comment
There was a problem hiding this comment.
looking good- just a couple of comments
| jobs: | ||
| build_docs: | ||
| if: github.repository_owner == 'aws' | ||
| if: github.repository_owner == 'aws' && github.event.pull_request.head.ref != 'phpcs-workflow-tests' |
There was a problem hiding this comment.
I think this can be removed from here and the other workflow files unless there's something I'm missing
There was a problem hiding this comment.
This will be removed before merging, right?
There was a problem hiding this comment.
This is a separate branch where I just do testing on it's own PR so I can observe the workflow behavior, it isn't intended to merge. The src/PhpcsWorkflowTest.php file only exists in this testing branch. The actual feature is here #3347
There was a problem hiding this comment.
This branch also skips the other workflow jobs so I don't have to wait a long time for the coding-standards job to finally run.
There was a problem hiding this comment.
I can see the workflow produces the correct violations/comments (with suggested change)- Let's see if we can get this to publish comments on the PR with a suggestion. Smithy does that with incorrect changelog entries here: https://github.com/smithy-lang/smithy/blob/main/.github/workflows/changelog-ci.yml
There was a problem hiding this comment.
Sounds good! I'll see if i can implement that similarly. I just wanted to get a sort of proof of concept through just the workflow outputs first before getting PR comments to suggest formatting changes.
2 participants
Description of changes:
This PR serves as a place to test workflow behavior specifically the way the coding-standards job that uses PHPCS and PHPCBF.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.