Skip to content

Sync AWS service models and add new clients - #125

Merged
kuhe merged 2 commits into
developfrom
kuhe/feat/new_clients
Nov 12, 2026
Merged

kuhe merged 2 commits into
developfrom
kuhe/feat/new_clients

Conversation

@kuhe

@kuhe kuhe commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Add some new clients so we can write more tests.

@kuhe
kuhe marked this pull request as ready for review November 11, 2026 21:49
@kuhe
kuhe requested a review from a team as a code owner November 11, 2026 21:49
[project]
name = "aws_sdk_iam"
version = "0.12.0"
description = "aws_sdk_iam client"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up note: We should update the code generator to create better descriptions. This isn't great.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added to my todo list, which really exists

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all existing clients, we should be porting over the related changelog entries that got shipped to other SDKs like boto3

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a todo or are you asking for this PR?

the existing clients don't have historical changes, and a changelog message for a change that can't be observed because it was not incrementally released doesn't make sense to me

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have been tracking API updates. See this example from the changelog entry: https://github.com/aws/aws-sdk-python/blob/develop/clients/aws-sdk-bedrock-runtime/CHANGELOG.md#v070

When we update the model + codegen, that is a pending incremental change we are going to ship. There are some associated changelog entries the service team sent out with that and we should document them so the next release renders them in the changelog.

@arandito arandito Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does our release pipeline still replace the client READMEs with a filled out template? I'm not sure if that was removed when we internalized client gen.

If not, can we start using a template to create READMEs similar to existing clients: https://github.com/aws/aws-sdk-python/blob/develop/clients/aws-sdk-dynamodb/README.md

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the smithy-python generator should take over writing readmes, and the overlays eventually removed

@kuhe
kuhe merged commit f95909b into develop Nov 12, 2026
5 of 6 checks passed
@kuhe
kuhe deleted the kuhe/feat/new_clients branch November 12, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants