Repository navigation
Add web identity token credential resolvers and providers - #126
Merged
Merged
Conversation
kuhe
requested changes
Nov 12, 2026
| async with self._refresh_lock: | ||
| self._credentials = None | ||
|
|
||
| async def _assume_role_with_web_identity(self) -> AWSCredentialsIdentity: |
Contributor
There was a problem hiding this comment.
try to reduce the duplication with the guidelines from https://github.com/smithy-lang/smithy-python/blob/develop/designs/async-and-sync-duality.md
Contributor
Author
There was a problem hiding this comment.
After going through both resolvers, _call was the only part worth sharing, since it holds the SEP retry rules. I moved it into a single fetch_web_identity_credentials program in _web_identity.py, which both resolvers now run with run_program / run_program_async.
kuhe
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
WebIdentityCredentialsResolver/AsyncWebIdentityCredentialsResolver: read the OIDC token file before each refresh, call STS unsigned, cache the credentials, and retryExpiredTokenException(re-reading the token) andIDPCommunicationError.WebIdentityTokenEnvProvider/ProfileWebIdentityProvider(plusAsync*versions), registered for the default chain: configured byAWS_WEB_IDENTITY_TOKEN_FILE+AWS_ROLE_ARN, or by a profile'sweb_identity_token_file+role_arn.role_arn+web_identity_token_filewithoutsource_profile/credential_source.NoAuthResolver()and a placeholder credentials resolver, so it never builds its own credential chain.Testing
tests/unit/test_web_identity.py,test_assume_role.py) cover sync and async: request building, the SEP retry rules, unreadable/empty token files, caching and invalidation, concurrency, the providers, routing, and a default-chain test using the real STS client over a mock transport that asserts the request is unsigned.make static-analysis,make aio-checkandmake test-unitpass forpackages/aws-credentials-stsAssumeRoleWithWebIdentityfrom that pool.cognito-identity get-open-id-tokenand wrote it to a file.AWS_WEB_IDENTITY_TOKEN_FILE/AWS_ROLE_ARN, with no other credentials configured.GetCallerIdentitywith the returned credentials. All four cases returned the web identity role's assumed-role ARN, and a corrupted token failed withInvalidIdentityTokenException.Follow-up
A follow-up PR will add the web identity feature IDs to the providers once the smithy-python change is merged and released.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.