Repository navigation
Use sdk id for package name instead of filename - #127
Merged
Merged
Conversation
arandito
force-pushed
the
update-package-naming-logic
branch
from
November 12, 2026 01:49
f77ed10 to
c25627d
Compare
arandito
force-pushed
the
update-package-naming-logic
branch
from
November 12, 2026 03:07
c25627d to
7597ea4
Compare
arandito
marked this pull request as ready for review
November 12, 2026 03:59
Alan4506
approved these changes
Nov 12, 2026
stobrien89
approved these changes
Nov 12, 2026
kuhe
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AWS SDK clients should be named using the models
sdkIdproperty on theaws.api#servicetrait. Currently,gen_clients.pyuses the model's filename.Models currently match the sdk id but this is a fragile requirement. This PR updates client package name construction to use
sdkId.Ran
make clientsand confirmed no clients changed.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.