fix: backport upstream VS Code advisory fixes (copilot config scope, iframe parentOrigin, notebook render) - #286
Merged
Conversation
…r backported iframe parentOrigin and mermaid render hardening Add a quilt patch that reads the Copilot advanced debug CAPI/proxy URL override settings only from user (global) scope so a workspace .vscode/settings.json cannot redirect requests. Register the existing web worker extension host iframe parentOrigin hardening (web-server/webview.diff) and document the notebook mermaid render finding, which has no equivalent vulnerable sink in this branch's shipped source, in backported-patches.json.
azmkercso
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description of Changes
Addresses the upstream
microsoft/vscodesecurity advisories flagged by the "Scan GitHub Security Advisories" step of the nightly Security Scan (all fixed upstream in VS Code 1.128.1), by backporting the upstream fixes where the affected code ships and registering each finding inpatches/backported-patches.json.f05bcd1a: the advanced debug CAPI/proxy URL override settings are now read only from user (global) configuration, so a malicious workspace.vscode/settings.jsoncannot redirect requests to an attacker host. New quilt patch underpatches/common/, added to all four series.parentOriginvalidation — the existingpatches/web-server/webview.diffalready forcesparentOrigintowindow.originin the non-validated path (equivalent to upstream236fa7d8); registered as backported, no code change.bc2d56c6targets an extension not present in Code Editor; the shipped mermaid extension renders viatextContent/escaped HTML and the markdown notebook renderer uses DOMPurify, so there is no equivalent unsafe sink. Registered with apatch_path: "N/A"evidence note.Testing
./scripts/prepare-src.sh code-editor-sagemaker-server(andcode-editor-server) apply the full patch series cleanly, including the new Copilot patch (no rejects)../scripts/security-scan.sh scan-github-advisoriesreports 0 concerning advisories (all three findings recognized as backported/handled).Screenshots/Videos
N/A
Additional Notes
Backport patch carries
@backported+@finding-idmetadata for the rebase tooling and future removal (remove when Code-OSS ≥ 1.128.1). The same fix is being raised in parallel against the other active branches; the set of applicable changes differs per branch (older branches do not ship the Copilot extension).Backporting
Raised in parallel against
main,1.0,1.1, and1.2.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.