Repository navigation
Protect all 35 verified offline retrieval cases - #147
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Comment |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Vision — automated project maintainer Independent verification (temporary credential): success Head: {
"head_sha": "94d911284b78df4c34e60bc0e4165ef145e85da8",
"base_sha": "66bd44d0902d644f7fad80827a3739bd3eda5130",
"approved": true,
"summary": "Approved for prepublication review. The full diff changes only 27 regression-baseline flags from false to true; reversing them recovers the exact base file. A fresh source-pinned index produced 1,603 documents. Its offline replay reproduced 35 hits and 69 citations across 65 cases, and all 27 individual negative controls behaved as intended. Locked checks, doctor, package build, and installed-wheel stdio smoke passed. Public main still matches the base; hosted CI for this unpublished head is pending, not a local verification pass.",
"commands": [
{
"command": "git clone --depth=1 https://github.com/ayhammouda/python-docs-mcp-server.git repo",
"exit_code": 0
},
{
"command": "git fetch --depth=1 origin 94d911284b78df4c34e60bc0e4165ef145e85da8",
"exit_code": 0
},
{
"command": "git fetch --depth=1 origin 66bd44d0902d644f7fad80827a3739bd3eda5130",
"exit_code": 0
},
{
"command": "git diff --check 66bd44d0902d644f7fad80827a3739bd3eda5130 HEAD",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv sync --locked --dev",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv run --locked ruff check src/ tests/ benchmarks/ ops/ .github/scripts/",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv run --locked pyright src/ benchmarks/",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv run --locked pytest --tb=short -q",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv run --locked python -m benchmarks validate-corpus --corpus docs/benchmarks/corpus.yml --schema docs/benchmarks/corpus.schema.json",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv build --no-sources",
"exit_code": 0
},
{
"command": "XDG_CACHE_HOME=\"$PWD/.verifier-cache\" /usr/local/bin/uv run --locked python-docs-mcp-server build-index --versions 3.11,3.12,3.13",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv run --locked python -m benchmarks.regression --index .verifier-cache/mcp-python-docs/index.db --output .review-actual.json",
"exit_code": 0
},
{
"command": "/usr/local/bin/uv run --locked python - [independent baseline and 27 negative-control assertions via stdin]",
"exit_code": 0
},
{
"command": "XDG_CACHE_HOME=\"$PWD/.verifier-cache\" /usr/local/bin/uv run --locked python-docs-mcp-server doctor",
"exit_code": 0
},
{
"command": "../.review-wheel-venv/bin/python -m pytest --import-mode=importlib test_stdio_smoke.py -q",
"exit_code": 0
},
{
"command": "git ls-remote origin refs/heads/main",
"exit_code": 0
}
],
"blockers": []
} |
|
Vision — automated project maintainer Merge decision for exact head Proceed through SHA-matched pdctl merge, then confirm main CI. This strengthens regression protection only; no runtime or answer-quality improvement and no release claim. |
|
Vision — automated project maintainer Post-merge follow-up for Runs: CI, Scorecard. GitHub reports an active hosted-runner assignment incident. This is evidence of infrastructure acquisition failure, not failed product tests. I attempted the failed-job rerun through the authorized fixed-repository broker; it rejected the endpoint as outside its allowlist. No alternate identity, workflow change, empty commit, check suppression or repeated unsupported request was used. Recovery is pending supported runner reruns; retain all gates and do not claim post-merge completion or a release. |
1 participant
Refs #63.
User problem and decision
The historical frozen gate protects 8 hits while verified merged main has 35. Protect the verified gains with exactly 27 false→true baseline flags (original 26 plus EX-015). No other baseline bytes change: 65 case keys, citations, timings, corpus SHA, 1,603-document floor and two-second ceiling are preserved. No source/scorer/corpus/tests/workflows changed. This strengthens the gate; it does not improve runtime retrieval or measure answer accuracy.
Owner decision: #63 (comment)
Base: 66bd44d. Local committed head ccfbe48b873bdd440aacfddc8ed2155fe4412cb5; published head 94d9112 has matching tree 0b78e54982d5e2bc1d91a270ede070ac0bf3ed56 and exact base.
Acceptance and evidence
94d911284b78df4c34e60bc0e4165ef145e85da8has the exact owner-reviewed tree and base.pdctl verifyin the next full review window; publication output itself only returned the approved ref.Supervisor review
Vision explicitly authorizes only upward regression-baseline strengthening. Independent justification is mandatory. No test weakening, corpus answer edits, new behavior or unrelated dependencies.
Limitations and review
Developer index was retained, not rebuilt; those results do not replace independent source-pinned evidence. One existing packaging deprecation warning. No generated-answer, timing-improvement or named-client claim. CodeRabbit skipped this baseline-only change (path filters; another integration reports fewer than 10 stars). No actionable inline/submitted findings or review threads at 2026-10-05 18:37 UTC. A skipped review is not approval; broker independent review remains mandatory. Outcome review 2026-10-17; reject nonreproducible protections or downward relaxation and revisit on actual regressions/feedback.