Conversation
|
Fix the broken backend module, but the database compare still can't apply the changes. |
The cost and score columns were declared as double(10,6) and double(5,4). Doctrine maps double to its FloatType, which drops precision and scale when rendering a column, so the declared width could never be materialised: the columns end up as plain double in the database. The schema comparator does compare the parsed scale, however, so every "Analyze Database Structure" run reported a change for these columns, generated an ALTER TABLE without a scale, applied nothing, and reported the very same change again on the next run. Declaring the columns as decimal fixes this, as DecimalType honours precision and scale, so the comparison converges after one migration. It is also the correct type for monetary values, avoiding binary float rounding on accumulated cost sums. As a side effect this drops the non-standard double(M,D) syntax, deprecated since MySQL 8.0.17 and removed in newer MySQL versions. Resolves #27
Member
Author
|
@NeoBlack Can you please check again with the current patchset. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #27