[!!!][TASK] 2.0 – Drop legacy layer, require TYPO3 v13/v14 by davidsteeb · Pull Request #53 · b13/backendpreviews

davidsteeb · 2026-06-11T14:50:16Z

Cleanup release 2.0: raise the minimum to TYPO3 v13.4 / v14 and PHP 8.2, and remove the v10/v11/v12 compatibility layer. The ViewHelpers stay (no core replacement).

⚠️ Breaking: drops support for TYPO3 v10/v11/v12 and PHP < 8.2.

Removed

Classes/Hooks/BackendPreviewRenderer.php (PageLayoutViewDrawItemHookInterface, gone since v12) incl. its SC_OPTIONS registration and public: true in Services.yaml
ext_tables.php (only registered the < v12 backend skin)
Classes/Listener/BootCompleted.php – registered unused Fontawesome icons (templates use the core icons actions-exclamation-*-alt)
Build/phpstan12.neon + phpstan-baseline12.neon, and '12' from the CI matrix

Simplified

ext_localconf.php → just the (now unconditional) stylesheet registration
ContentPreview: renders via ViewFactoryInterface on both paths (RecordInterface/v14 and array/v13) → StandaloneView (removed in v14) is gone, shared createView() helper
DatabaseRowService: removed the pre-v12 manual file-field fallback (!$foundOne)
GetDatabaseRecordViewHelper: removed the v12 QueryBuilder::add() branch

Constraints

PHP ^8.2, TYPO3 ^13.4 || ^14.3, version 2.0.0 (composer.json + ext_emconf.php)

Quality

PHPStan baselines regenerated against real v13.4.31 and v14.3.3: v14 from 12 → 3 entries, v13 also 3 (same set — only the unavoidable v13↔v14 Record-API differences)
PHPStan v13 + v14 green, php-cs-fixer green, CI matrix now v13/v14
PartialsLegacy kept (still used on v13 via [typo3.version < 14] in page.tsconfig)

Relates BEXT-596.

BREAKING: drops support for TYPO3 v10, v11 and v12 (and PHP < 8.2). - Remove legacy PageLayoutView hook (BackendPreviewRenderer) and its registration; v12+ always uses the previewRenderer. - Remove ext_tables.php (only registered the < v12 backend skin). - Reduce ext_localconf.php to the (now unconditional) stylesheet entry. - Remove BootCompleted listener (registered unused Fontawesome icons). - ContentPreview: render previews via ViewFactoryInterface on both the RecordInterface (v14) and the array (v13) path, dropping StandaloneView. - DatabaseRowService: drop the pre-v12 manual file-field fallback. - GetDatabaseRecordViewHelper: drop the v12 QueryBuilder::add() branch. - CI/PHPStan: drop the v12 matrix entry, config and baseline; regenerate the v14 baseline (12 -> 3 entries). - Bump constraints: PHP ^8.2, TYPO3 ^13.4 || ^14.3, version 2.0.0. Relates: BEXT-596

Relates: BEXT-596

The previous regeneration ran against a broken local v13 vendor state (mixed v13/v14), producing v14-style entries. Restore the actual v13 errors reported by CI (instanceof-always-false + checkRecordEditAccess), which differ from the v14 baseline. Relates: BEXT-596

achimfritz

👍

achimfritz · 2026-06-12T11:33:25Z

-                $row['allImages-visible'] = $this->countVisibleFileReferences($row['allImages']);
+            if ($row[$fieldName] ?? false) {
+                $row['all' . $variableName] = $this->fileRepository->findByRelation('tt_content', $fieldName, $row['uid']);
+                $row['all' . $variableName . '-visible'] = $this->countVisibleFileReferences($row['all' . $variableName]);


extendRow is only called for v13 (because in v14 we have the Record Object).

I would suggest to drop die "-visible" variables, because they are also not available in v14

achimfritz · 2026-06-12T11:38:17Z

+            if ($row[$fieldName] ?? false) {
+                $row['all' . $variableName] = $this->fileRepository->findByRelation('tt_content', $fieldName, $row['uid']);
+                $row['all' . $variableName . '-visible'] = $this->countVisibleFileReferences($row['all' . $variableName]);
            }


(maybe we can even do more cleanups in this Method, to become similar to v14)

Copilot

Pull request overview

This PR prepares the extension’s 2.0 release by removing the legacy TYPO3 v10/v11/v12 compatibility layer and raising the minimum requirements to TYPO3 v13/v14 with PHP 8.2+, simplifying backend preview rendering to rely on the modern ViewFactory-based approach.

Changes:

Dropped legacy registration/hook paths (ext_tables.php, legacy hook class, unused boot listener) and simplified ext_localconf.php.
Refactored backend preview rendering to use ViewFactoryInterface on both v13 (array record) and v14 (Record API) paths; removed StandaloneView.
Updated version/constraints and CI/PHPStan configs to target TYPO3 13/14 only.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
ext_tables.php	Removed legacy (< v12) backend skin registration.
ext_localconf.php	Simplified to unconditional backend stylesheet registration.
ext_emconf.php	Bumped extension version and raised TYPO3 dependency range.
Configuration/Services.yaml	Removed DI entries for dropped legacy hook/listener classes.
composer.json	Bumped version and raised PHP/TYPO3 requirements.
Classes/ViewHelpers/GetDatabaseRecordViewHelper.php	Simplified ordering logic for UID list ordering.
Classes/Service/DatabaseRowService.php	Removed pre-v12 file-field fallback logic; simplified file field resolving.
Classes/Listener/BootCompleted.php	Removed unused icon registration listener.
Classes/Hooks/BackendPreviewRenderer.php	Removed deprecated hook-based renderer.
Classes/Backend/Preview/StandardContentPreviewRenderer.php	Updated legacy render call to pass `PageLayoutContext`.
Classes/Backend/Preview/ContentPreview.php	Refactored to shared `createView()` + unified ViewFactory rendering path; removed StandaloneView.
Build/phpstan13.neon	Removed excludes related to removed legacy hook file.
Build/phpstan12.neon	Removed TYPO3 12 PHPStan config.
Build/phpstan.neon	Removed excludes related to removed legacy hook file.
Build/phpstan-baseline13.neon	Cleaned baseline entries tied to removed code paths.
Build/phpstan-baseline12.neon	Removed TYPO3 12 baseline.
Build/phpstan-baseline.neon	Cleaned baseline entries tied to removed code paths.
.github/workflows/ci.yml	Removed TYPO3 12 from CI matrix and related steps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

    'constraints' => [
        'depends' => [
-            'typo3' => '10.4.0-14.99.99',
+            'typo3' => '13.4.0-14.99.99',


-        } else {
-            $queryBuilder->add('orderBy', 'FIELD(uid,' . implode(',', $uids) . ')');
-        }
+        $queryBuilder->getConcreteQueryBuilder()->addOrderBy('FIELD(uid,' . implode(',', $uids) . ')');


davidsteeb added 2 commits June 11, 2026 16:46

[TASK] Regenerate v13 PHPStan baseline for 2.0 cleanup

4b152f3

Relates: BEXT-596

davidsteeb requested review from achimfritz and bmack and removed request for achimfritz June 11, 2026 15:02

davidsteeb self-assigned this Jun 11, 2026

davidsteeb requested a review from achimfritz June 11, 2026 15:14

achimfritz approved these changes Jun 12, 2026

View reviewed changes

bmack requested a review from Copilot July 20, 2026 07:47

Copilot started reviewing on behalf of bmack July 20, 2026 07:47 View session

Copilot AI reviewed Jul 20, 2026

View reviewed changes

Navigation Menu

Uh oh!

[!!!][TASK] 2.0 – Drop legacy layer, require TYPO3 v13/v14 - #53

[!!!][TASK] 2.0 – Drop legacy layer, require TYPO3 v13/v14#53
davidsteeb wants to merge 3 commits into
mainfrom
BEXT-596-cleanup-v13-v14

davidsteeb commented Jun 11, 2026

Uh oh!

achimfritz left a comment

Uh oh!

achimfritz Jun 12, 2026

Uh oh!

achimfritz Jun 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

davidsteeb commented Jun 11, 2026

Removed

Simplified

Constraints

Quality

Uh oh!

achimfritz left a comment

Choose a reason for hiding this comment

Uh oh!

achimfritz Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

achimfritz Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants