Repository navigation
feat(report): chart builder validity-predicate and resting metrics - #214
Merged
Merged
Conversation
Collaborator
✅ Heimdall Review Status
|
Contributor
Author
|
Companion PRs: base/base#6245 (allowlists these series in base-bench) and protocols/base-metal#454 on GHE (schedules the validity workloads). |
wlawt
approved these changes
Oct 28, 2026
wlawt
self-requested a review
October 28, 2026 15:59
wlawt
approved these changes
Oct 28, 2026
Define charts for the reth_base_builder_validity_*, predicate_* and resting_predicate_* series base-bench scrapes from the native builder, plus the validity-flow txs/gas per block series it already allowlisted. ChartGrid only renders keys in CHART_CONFIG, so these were scraped but never shown.
Add rescan_budget_exhausted, rescan_read_error and unsupported to match the base-bench allowlist, so every ValidityEvaluationOutcome has a chart.
Match the base-bench allowlist: validity transactions admitted to the pool per block (added / replaced), to read against validity txs included per block.
fahimahmedx
force-pushed
the
fahim/validity-predicate-charts
branch
from
October 28, 2026 17:38
eb1c88c to
83b731e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
CHART_CONFIGentries for the validity-predicate series the native builder emits andbase-benchscrapes per block, so they render in the dashboard.ChartGridonly draws keys present inCHART_CONFIG, so until now these were scraped but never shown.New charts (all under the
reth_base_builder_prefix):validity_candidate_handling_duration_avg,validity_predicate_eval_duration_per_block_avg,validity_predicate_rescan_duration_avgCompanion to base/base (allowlists these series in
etc/systems/src/prometheus_metrics.rs) and protocols/base-metal (schedules validity workloads). After this merges,benchmark_workload_config.dashboard.revisionin base-metal should be bumped to pick it up.Testing
yarn checkandyarn testpass (16 tests).tsc --noEmitreports no errors inmetricDefinitions.ts; the 15 errors it does report infilter.test.ts/BenchmarkLoadTestDetail.tsxare pre-existing onmain.