Skip to content

refactor(report): drop history and narration comments from metricDefinitions #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0x00101010 merged 1 commit into from
Nov 3, 2026
Merged

refactor(report): drop history and narration comments from metricDefinitions #217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions report/src/metricDefinitions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ChartConfig } from "./types"; // Import from types.ts
import { ChartConfig } from "./types";
export const CHART_CONFIG = {
"latency/send_txs": {
type: "line",
Expand Down Expand Up @@ -32,7 +32,6 @@ export const CHART_CONFIG = {
unit: "ns",
},
"chain/account/reads.50-percentile": {
// Added
type: "line",
title: "Account Reads",
description:
Expand All @@ -47,7 +46,6 @@ export const CHART_CONFIG = {
unit: "ns",
},
"chain/execution.50-percentile": {
// Added
type: "line",
title: "Execution (EVM)",
description:
Expand All @@ -70,7 +68,7 @@ export const CHART_CONFIG = {
},
"chain/storage/updates.50-percentile": {
type: "line",
title: "Storage Updates", // Renamed from 'Storage Writes' for consistency
title: "Storage Updates",
description:
"Shows the median time taken for updating storage during state validation",
unit: "ns",
Expand All @@ -83,7 +81,6 @@ export const CHART_CONFIG = {
unit: "ns",
},
"chain/crossvalidation.50-percentile": {
// Added
type: "line",
title: "Cross Validation",
description:
Expand Down Expand Up @@ -705,7 +702,6 @@ export const SORTED_CHART_CONFIG: [string, ChartConfig][] = Object.entries(
const aIndex = CHART_CONFIG_ORDER.indexOf(a[0] as keyof typeof CHART_CONFIG);
const bIndex = CHART_CONFIG_ORDER.indexOf(b[0] as keyof typeof CHART_CONFIG);

// if both doesn't exist, sort it last (infinity)
if (aIndex === -1 && bIndex === -1) {
return 0;
}
Expand Down
Loading