docs(configuration): replace OP Mainnet admin addresses with Base's - #1959
Open
kriss39 wants to merge 1 commit into
Open
docs(configuration): replace OP Mainnet admin addresses with Base's#1959kriss39 wants to merge 1 commit into
kriss39 wants to merge 1 commit into
Conversation
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
The Admin Roles / Service Roles tables on
specifications/reference/configurationlist OP Mainnet's addresses, not Base's. The four linked addresses were:0x5a0Aae59…3d2A0x7bB41C30…595c0x6B1BAE59…4E3b(linked to optimistic.etherscan.io)0x8cC51c30…6a6d0x9BA6e03D…6b3A0x819501cd…d1020x09f7150D…dAf20x7bB41C30…595c0x5a0Aae59…is OP Mainnet'sProxyAdmin.owner()and0x09f7150D…is OP Mainnet'sOptimismPortal.guardian(), so this looks like a leftover from copying the OP "standard configuration" page. The new values match the Contract Addresses page.Notes to reviewers
Verified against L1 mainnet:
ProxyAdmin(0x0475cBCA…059E).owner()→0x7bb41c3008b3f03fe483b28b8db90e19cf07595cOptimismPortal(0x49048044…E97e).guardian()→0x7bb41c3008b3f03fe483b28b8db90e19cf07595cProxyAdmin(0x4200…0018).owner()→0x8cc51c3008b3f03fe483b28b8db90e19cf076a6d, which is0x7bB41C30…595c+0x1111…1111(aliased L1 owner, as the row says)How has it been tested?
node scripts/lint-mdx.js docs/specifications/reference/configuration.mdxandnode scripts/validate-docs-structure.jspass.Screenshots
N/A (four table cells change, no layout change)