docs(connect-to-base): add Vibenet details and stop linking the unpublished connecting-to-base page - #1964
Open
kriss39 wants to merge 2 commits into
Open
docs(connect-to-base): add Vibenet details and stop linking the unpublished connecting-to-base page#1964kriss39 wants to merge 2 commits into
kriss39 wants to merge 2 commits into
Conversation
…lished connecting-to-base page
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
docs/base-chain/quickstart/connecting-to-base.mdx(the page with the Vibenet tab and the "Add to MetaMask" buttons) is in.mintignore, so it never ships; its URL redirects to/get-started/connect-to-base, which only lists Mainnet and Sepolia. Six places still send readers to the old URL for Vibenet-specific instructions, and they all land on a page with no Vibenet on it:build-on-base/test-on-vibenet.mdx— "To add Vibenet to your wallet, see Connecting to Base" (plus the Next Steps card)specifications/native-account-abstraction.mdx— "learn more in the guide to connecting to vibenet" (with a#vibenetanchor that doesn't exist on the target)get-started/base-chain.mdx— the "Connect to Base" card whose copy promises "Base Mainnet, Base Sepolia, or Vibenet"base-chain/api-reference/rpc-overview.mdxandspecifications/reference/smart-contracts.mdx— generic "network details" linksThis PR:
https://rpc.vibes.base.org, chain ID84538453, explorer) to the Network Details table onget-started/connect-to-base, with one sentence on what Vibenet is and a link to Test on Vibenet for the faucet/get-started/connect-to-base(or to/build-on-base/test-on-vibenetwhere the context is Vibenet itself)docs.json,.mintignoreand the hidden page are untouched; nothing is added to the Get Started tab.Notes to reviewers
Chain ID checked against the RPC:
eth_chainIdonhttps://rpc.vibes.base.orgreturns0x509f455= 84538453, matchingbuild-on-base/test-on-vibenet.If the plan is to bring the hidden page back (it also carries the MetaMask "add network" buttons), this PR is still a safe interim: the redirect keeps working and the links then just point at the shipped page.
How has it been tested?
node scripts/lint-mdx.json all six files (the one warning onrpc-overview.mdx:119is pre-existing),node scripts/validate-docs-structure.jsandnode scripts/check-terminology.jspass. No remaining links to/base-chain/quickstart/connecting-to-baseoutside the hidden file itself.Screenshots
N/A (one extra table column and a sentence; link target changes)