Skip to content

WIP: A refusal could be thrown away while an earlier one was being written #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jorgemanrubia wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

WIP: A refusal could be thrown away while an earlier one was being written #767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ed6136
A refusal is read on one goroutine and written on another
jorgemanrubia Sep 19, 2026
36fd490
Admitting a late refusal and deciding the ledger is whole are one dec…
jorgemanrubia Sep 19, 2026
1a2ccca
A turn ends away from the reader, so the reader only reads
jorgemanrubia Sep 19, 2026
67904ac
A refusal read for a turn is put on that turn, not on whatever is left
jorgemanrubia Sep 19, 2026
92ebdf4
Two ids that begin alike are two refusals, and the one that fills the…
jorgemanrubia Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions internal/connector/dispatcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1351,8 +1351,10 @@ type refusalRecorder struct {
pending int
}

// refusalWriteTimeout bounds a refusal's write, which runs on the goroutine
// reading the agent's stream.
// refusalWriteTimeout bounds a refusal's write. Which goroutine it runs on is
// the driver's: on most it is the one reading the agent's stream, and the
// codex driver writes on a goroutine of its own precisely because ten
// seconds is more than a reader can afford to spend.
const refusalWriteTimeout = 10 * time.Second

// RecordRefusal implements driver.RefusalRecorder.
Expand Down
Loading
Loading