Guide Codex through sandboxed Keychain auth - #471
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The guidance mishandles the successful authenticated: false response, and some credential boundaries are not independently regression-tested.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Updates the embedded HEY skill to recover safely from macOS Codex sandbox restrictions on Keychain access.
Changes:
- Adds an approved, narrowly scoped authentication probe and command retry.
- Documents prohibited credential and sandbox workarounds.
- Adds regression checks for the new guidance.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
skills/hey/SKILL.md |
Documents sandbox-aware authentication recovery. |
skills/embed_test.go |
Verifies embedded security guidance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What changed
Validation
make testmake lintmake buildCloses #433
Summary by cubic
Guides the HEY skill through macOS Codex Keychain sandbox issues so auth failures no longer get misreported as blocked tasks when the sandbox hides stored credentials.
hey auth status --jsononce with user-approved elevated sandbox permission before reporting a task blocked; if it confirms credentials are available, reruns only the exactheycommand the user requested.HEY_NO_KEYRING=1.Closes #433.
Written for commit bd93cff. Summary will update on new commits.