Reconcile Omarchy plugin install failures - #472
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approved
The implementation is fail-closed, preserves retry behavior, and includes focused regression tests.
Review effort: Balanced
Findings: None
What changed in this PR
Reconciles failed Omarchy plugin commands with the shell’s actual plugin state, resolving #467.
Changes:
- Accepts installation when
37signals.heyis present and enabled. - Preserves failure and retry state otherwise.
- Adds regression coverage for success, failure, and Git progress output.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
| internal/cmd/omarchy_plugin.go | Verifies final plugin state after an add failure. |
| internal/cmd/omarchy_plugin_test.go | Covers reconciliation and Git progress scenarios. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
omarchy plugin addwith the running shell's plugin state37signals.heyis present and enabledValidation
go test ./internal/cmd -run 'OmarchyPlugin|SetupOmarchy|SetupWizardStep3CloneFailure' -count=1make testmake lintmake buildCloses #467
Summary by cubic
Stops
omarchy plugin addfailures from leaving an enabled plugin stuck in a pending retry state.After an add error, the install now checks the shell's plugin state and succeeds when
37signals.heyis present and enabled. If the plugin is absent or disabled, the original failure and retry throttle stay intact.Closes #467
Written for commit c53dd74. Summary will update on new commits.