Skip to content

Reconcile Omarchy plugin install failures - #472

Merged
robzolkos merged 1 commit into
mainfrom
rob/issue-467-reconcile-omarchy-install
Sep 20, 2026
Merged

robzolkos merged 1 commit into
mainfrom
rob/issue-467-reconcile-omarchy-install

Conversation

@robzolkos

@robzolkos robzolkos commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • reconcile a failed omarchy plugin add with the running shell's plugin state
  • accept the install only when 37signals.hey is present and enabled
  • preserve the original failure and pending retry state when the plugin is absent or disabled
  • cover the reported command-level outcome and successful Git progress output

Validation

  • go test ./internal/cmd -run 'OmarchyPlugin|SetupOmarchy|SetupWizardStep3CloneFailure' -count=1
  • make test
  • make lint
  • make build

Closes #467


Summary by cubic

Stops omarchy plugin add failures from leaving an enabled plugin stuck in a pending retry state.

After an add error, the install now checks the shell's plugin state and succeeds when 37signals.hey is present and enabled. If the plugin is absent or disabled, the original failure and retry throttle stay intact.

Closes #467

Written for commit c53dd74. Summary will update on new commits.

Review in cubic

@robzolkos
robzolkos requested a review from a team as a code owner September 20, 2026 17:17
Copilot AI balanced review requested due to automatic review settings September 20, 2026 17:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approved

The implementation is fail-closed, preserves retry behavior, and includes focused regression tests.

Review effort: Balanced
Findings: None

What changed in this PR

Reconciles failed Omarchy plugin commands with the shell’s actual plugin state, resolving #467.

Changes:

  • Accepts installation when 37signals.hey is present and enabled.
  • Preserves failure and retry state otherwise.
  • Adds regression coverage for success, failure, and Git progress output.

[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

File Description
internal/​cmd/​omarchy_plugin.go Verifies final plugin state after an add failure.
internal/​cmd/​omarchy_plugin_test.go Covers reconciliation and Git progress scenarios.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@robzolkos
robzolkos merged commit 966d758 into main Sep 20, 2026
26 checks passed
@robzolkos
robzolkos deleted the rob/issue-467-reconcile-omarchy-install branch September 20, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hey setup omarchy reports "bar plugin: failed" when the clone actually succeeds

2 participants