fix(cli): reject required positionals after optional ones - #415
Merged
codeforester merged 1 commit intoSep 3, 2026
Conversation
codeforester
deleted the
bug/407-20260904-lib-cli-sh-optional-positional-declared-before-a-required-on
branch
September 3, 2026 20:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject declaration orders that put a required positional after an optional or defaulted positional, preventing misleading runtime missing-argument failures.
Issue
Fixes #407
Validation
bats lib/bash/cli/tests/lib_cli.bats(28/28)env -u BASE_HOME BASE_CACHE_DIR=/private/tmp/base-bash-libs-407 ./tests/validate.sh(616/616 plus all repository contracts)Compatibility and security
Valid required-first and optional-tail declarations remain unchanged; the guard runs before model mutation.