Fix Base self-demo to use the owning runtime - #2085
Open
codeforester wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue
Fixes #2081
Validation
BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash bats cli/bash/commands/basectl/tests/demo.bats(12 passed)shellcheck demo/demo.shenv -u BASE_HOME BASE_BASH_LIBS_DIR=/Users/rameshhp/work/base-bash-libs/lib/bash BASE_CLI_SOURCE_DIR=/Users/rameshhp/work/base-cli/lib/python BASE_CACHE_DIR=/private/tmp/base-pr-train-2081 ./bin/base-test(1,115 pytest tests and 900 BATS tests passed)git diff --checkbasectl demo base --dry-run -- --non-interactiveDemo Impact
The documented self-demo now resolves nested
basectlandbase-wrappercalls from the same Base checkout asdemo/demo.sh, so an incompatible globalbasectlcannot intercept the run. ExplicitBASE_DEMO_BASECTLandBASE_DEMO_BASE_WRAPPERoverrides remain available to tests and integrators.Notes
The real demo remains trust-gated by the existing manifest approval boundary; validation did not persist a user-owned trust grant.
.ai-context/is unchanged because the public command shape and product architecture are unchanged.