refactor(toolchains): share Python version config settings - #4159
Open
dzbarsky wants to merge 2 commits into
Open
refactor(toolchains): share Python version config settings#4159dzbarsky wants to merge 2 commits into
dzbarsky wants to merge 2 commits into
Conversation
Generate each distinct Python version and flag predicate once per toolchain repository and reuse it across py_toolchain_suite calls. In our repo, this removes 79MB of retained heap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated toolchain BUILD files repeat Python version
config_settingpredicates for each suite.toolchain_suites_contentnow emits each distinct predicate once and passes its label topy_toolchain_suite, preserving version matching while reducing retained configuration data.In our repo, this removes 79MB of retained heap.
Validation:
buildifier -mode=checkon the three changed files andgit diff --checkpassed.bazel test --config=fast-tests --jobs=4 //tests/toolchains/... //tests/config_settings/...passed (36 passed, 1 skipped).