Skip to content

build: check presubmit.yml flag notation and diff task flags - #4392

Merged
rickeylev merged 1 commit into
bazel-contrib:mainfrom
rickeylev:bazelci_presubmit_checks
Nov 1, 2026
Merged

rickeylev merged 1 commit into
bazel-contrib:mainfrom
rickeylev:bazelci_presubmit_checks

Conversation

@rickeylev

Copy link
Copy Markdown
Collaborator

Upstream #4263 made build_flags and test_flags mappings of ? keys so
tasks can merge shared flag sets. Nothing enforces that notation, and
a one-line edit to a shared anchor can change dozens of jobs without
showing which ones in the diff.

A test now fails when a task writes its flags as a list or gives a ?
key a value. A dev tool, bazel run //dev/bazelci:diff_presubmit_flags,
shows each task's effective flags before and after an edit, resolving
YAML merges the way bazelci.py does. A new agent rule for .bazelci/
documents the conventions and points to both.

Upstream bazel-contrib#4263 made build_flags and test_flags mappings of `?` keys so
tasks can merge shared flag sets. Nothing enforces that notation, and
a one-line edit to a shared anchor can change dozens of jobs without
showing which ones in the diff.

A test now fails when a task writes its flags as a list or gives a `?`
key a value. A dev tool, `bazel run //dev/bazelci:diff_presubmit_flags`,
shows each task's effective flags before and after an edit, resolving
YAML merges the way bazelci.py does. A new agent rule for `.bazelci/`
documents the conventions and points to both.
@rickeylev
rickeylev requested a review from aignas as a code owner November 1, 2026 09:50
@rickeylev

Copy link
Copy Markdown
Collaborator Author

AI disclosure: an AI agent (Jetski) wrote this change at the direction of @rickeylev.

  • Human oversight: human-reviewed. @rickeylev directed the change and reviewed the diff, requesting several revisions before it was pushed.
  • Review comments: @rickeylev reads them and directs any follow-up changes. The agent doesn't reply to reviewers on its own.

This is an automatically generated agent comment.

@rickeylev
rickeylev merged commit 58d1807 into bazel-contrib:main Nov 1, 2026
13 checks passed
@rickeylev
rickeylev deleted the bazelci_presubmit_checks branch November 1, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant