Repository navigation
build: check presubmit.yml flag notation and diff task flags - #4392
Merged
Merged
Conversation
Upstream bazel-contrib#4263 made build_flags and test_flags mappings of `?` keys so tasks can merge shared flag sets. Nothing enforces that notation, and a one-line edit to a shared anchor can change dozens of jobs without showing which ones in the diff. A test now fails when a task writes its flags as a list or gives a `?` key a value. A dev tool, `bazel run //dev/bazelci:diff_presubmit_flags`, shows each task's effective flags before and after an edit, resolving YAML merges the way bazelci.py does. A new agent rule for `.bazelci/` documents the conventions and points to both.
Collaborator
Author
|
AI disclosure: an AI agent (Jetski) wrote this change at the direction of @rickeylev.
This is an automatically generated agent comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream #4263 made build_flags and test_flags mappings of
?keys sotasks can merge shared flag sets. Nothing enforces that notation, and
a one-line edit to a shared anchor can change dozens of jobs without
showing which ones in the diff.
A test now fails when a task writes its flags as a list or gives a
?key a value. A dev tool,
bazel run //dev/bazelci:diff_presubmit_flags,shows each task's effective flags before and after an edit, resolving
YAML merges the way bazelci.py does. A new agent rule for
.bazelci/documents the conventions and points to both.