Repository navigation
agents: add pipeline reuse, type uniformity, and WORKSPACE parity rules - #4421
Merged
rickeylev merged 1 commit intoNov 7, 2026
Merged
Conversation
Agent implementations of WORKSPACE features (such as bazel-contrib#4374 vs. bazel-contrib#4416) previously invented parallel repository rules, format converters, and runtime union-type branches instead of reusing existing pipelines and canonical data types. This duplicated Bzlmod logic, broke host portability for vendored `requirements.bzl` files, and modified unrelated code. Codify the design and Starlark rules from bazel-contrib#4416 so agents: * Trace existing call graphs and extend existing `WORKSPACE` rules and pipelines (`parse_requirements` -> `requirements.bzl.tmpl.workspace` -> `whl_library`) at the narrowest seam rather than adding parallel rules or format converters. * Extract pure helpers needed by both Bzlmod and `WORKSPACE` into standalone Bzlmod-agnostic `.bzl` files. * Preserve host portability in vendored `requirements.bzl` by emitting direct downloader attributes only when a package resolves to a single cross-platform distribution, falling back to `--hash` flags for platform-specific wheels. * Enforce uniform parameter, return, and collection types across callers and test fixtures without runtime union-type branches. * Leave working code untouched unless required and decompose multi-stage functions into focused helpers.
Collaborator
Author
|
AI Disclosure: This pull request was authored with AI assistance ( Handling of PR comments: Review comments and questions on this PR are monitored by @rickeylev, who may respond directly or direct an agent to draft responses and updates under human review before posting. This is an automatically generated agent comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent implementations of WORKSPACE features (such as #4374 vs. #4416)
previously invented parallel repository rules, format converters, and
runtime union-type branches instead of reusing existing pipelines and
canonical data types. This duplicated Bzlmod logic, broke host
portability for vendored
requirements.bzlfiles, and modifiedunrelated code.
Codify the design and Starlark rules from #4416 so agents:
WORKSPACErules andpipelines (
parse_requirements->requirements.bzl.tmpl.workspace->
whl_library) at the narrowest seam rather than adding parallelrules or format converters.
WORKSPACEintostandalone Bzlmod-agnostic
.bzlfiles.requirements.bzlby emittingdirect downloader attributes only when a package resolves to a single
cross-platform distribution, falling back to
--hashflags forplatform-specific wheels.
and test fixtures without runtime union-type branches.
functions into focused helpers.