Repository navigation
chore: remove the outdated version.bzl - #4494
Merged
aignas merged 4 commits intoNov 15, 2026
Merged
Conversation
Collaborator
Author
|
This PR was written by an AI coding agent (Claude Code) working under the direction of @aignas, who reviewed the design and the changes. Review comments will be handled by @aignas, possibly with the help of the agent; any agent-drafted replies or follow-up commits are reviewed by @aignas before being posted. An agent monitors CI only to retry flaky network failures. This comment was generated by an AI agent and reviewed by the user. |
rickeylev
approved these changes
Nov 13, 2026
rickeylev
enabled auto-merge
November 13, 2026 15:03
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Nov 14, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Nov 14, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Nov 14, 2026
aignas
enabled auto-merge
November 14, 2026 09:39
aignas
disabled auto-merge
November 15, 2026 05:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
version.bzlfile was out of date and misleading:BAZEL_VERSIONwas8.x, whereas.bazelversionis on Bazel 9.MINIMUM_BAZEL_VERSIONwas7.4.1, whereas the minimum supported versionthat CI tests is
7.xin.bazelci/presubmit.yml.SUPPORTED_BAZEL_VERSIONSwas only used for thebazel_binariesin theWORKSPACEsetup, but the integration tests are not run in theWORKSPACEbuilds and the versions used in the
bzlmodbuilds are inMODULE.bazel.bazel_version_to_binary_labelwas not used.With this change the file is removed. The
WORKSPACEsetup lists the versionsof the
bazel_binariesinMODULE.bazelthat still evaluate theWORKSPACEfiles and the agent instructions refer to the minimum supported version in
.bazelci/presubmit.yml.Fixes #4478