Skip to content

chore: remove the outdated version.bzl - #4494

Merged
aignas merged 4 commits into
bazel-contrib:mainfrom
aignas:chore.aignas.remove-version-bzl
Nov 15, 2026
Merged

aignas merged 4 commits into
bazel-contrib:mainfrom
aignas:chore.aignas.remove-version-bzl

Conversation

@aignas

@aignas aignas commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

The version.bzl file was out of date and misleading:

  • BAZEL_VERSION was 8.x, whereas .bazelversion is on Bazel 9.
  • MINIMUM_BAZEL_VERSION was 7.4.1, whereas the minimum supported version
    that CI tests is 7.x in .bazelci/presubmit.yml.
  • SUPPORTED_BAZEL_VERSIONS was only used for the bazel_binaries in the
    WORKSPACE setup, but the integration tests are not run in the WORKSPACE
    builds and the versions used in the bzlmod builds are in MODULE.bazel.
  • bazel_version_to_binary_label was not used.

With this change the file is removed. The WORKSPACE setup lists the versions
of the bazel_binaries in MODULE.bazel that still evaluate the WORKSPACE
files and the agent instructions refer to the minimum supported version in
.bazelci/presubmit.yml.

Fixes #4478

@aignas
aignas requested a review from rickeylev as a code owner November 13, 2026 13:43
@aignas

aignas commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator Author

This PR was written by an AI coding agent (Claude Code) working under the direction of @aignas, who reviewed the design and the changes. Review comments will be handled by @aignas, possibly with the help of the agent; any agent-drafted replies or follow-up commits are reviewed by @aignas before being posted. An agent monitors CI only to retry flaky network failures.

This comment was generated by an AI agent and reviewed by the user.

@rickeylev
rickeylev enabled auto-merge November 13, 2026 15:03
@rickeylev
rickeylev added this pull request to the merge queue Nov 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Nov 14, 2026
@aignas
aignas added this pull request to the merge queue Nov 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Nov 14, 2026
@aignas
aignas added this pull request to the merge queue Nov 14, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Nov 14, 2026
@aignas
aignas added this pull request to the merge queue Nov 14, 2026
@aignas
aignas removed this pull request from the merge queue due to a manual request Nov 14, 2026
@aignas
aignas enabled auto-merge November 14, 2026 09:39
@aignas
aignas disabled auto-merge November 15, 2026 05:24
@aignas
aignas merged commit 55afc88 into bazel-contrib:main Nov 15, 2026
15 checks passed
@aignas
aignas deleted the chore.aignas.remove-version-bzl branch November 15, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

name 'flag_alias' is not defined for bazel 7.0.0 and 8.0.0

2 participants