Repository navigation
agents: refine Rust conventions and CI flake/retry handling - #4501
Merged
rickeylev merged 1 commit intoNov 14, 2026
Merged
Conversation
In Rust crates, repeated string literals and duplicated format parsers can drift, bare `match` identifiers silently bind on typos, and `#[cfg(unix)]` `vec![...]` bases fail Windows `clippy::useless_vec`. In CI triage, log parsing leaves residual Buildkite `bk;t=` prefixes after ANSI removal, misclassifies runner DNS, git-mirror, and Windows `modextwd` file-lock flakes as code bugs, and `--rebuild` reruns discard passing jobs. Document module-qualified `match` constants, shared workspace parser crates, `HashMap` over linear `Vec` scans, and Windows-clean `#[cfg(unix)]` bases in the Rust rules and review prompt. Strip residual `bk;t=` timestamp prefixes and classify runner DNS, git-mirror, and `modextwd` cleanup flakes with Bazel-executed unit tests in `analyze-ci-failure`, and prefer in-place job retries over `--rebuild` in `retry-ci-job`.
Collaborator
Author
|
This pull request was prepared with AI assistance. Review comments on this PR This is an automatically generated agent comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Rust crates, repeated string literals and duplicated format parsers
can drift, bare
matchidentifiers silently bind on typos, and#[cfg(unix)]vec![...]bases fail Windowsclippy::useless_vec. InCI triage, log parsing leaves residual Buildkite
bk;t=prefixes afterANSI removal, misclassifies runner DNS, git-mirror, and Windows
modextwdfile-lock flakes as code bugs, and--rebuildrerunsdiscard passing jobs.
Document module-qualified
matchconstants, shared workspace parsercrates,
HashMapover linearVecscans, and Windows-clean#[cfg(unix)]bases in the Rust rules and review prompt. Stripresidual
bk;t=timestamp prefixes and classify runner DNS,git-mirror, and
modextwdcleanup flakes with Bazel-executed unittests in
analyze-ci-failure, and prefer in-place job retries over--rebuildinretry-ci-job.