Skip to content

agents: refine Rust conventions and CI flake/retry handling - #4501

Merged
rickeylev merged 1 commit into
bazel-contrib:mainfrom
rickeylev:agents_rust_and_ci_learnings
Nov 14, 2026
Merged

rickeylev merged 1 commit into
bazel-contrib:mainfrom
rickeylev:agents_rust_and_ci_learnings

Conversation

@rickeylev

Copy link
Copy Markdown
Collaborator

In Rust crates, repeated string literals and duplicated format parsers
can drift, bare match identifiers silently bind on typos, and
#[cfg(unix)] vec![...] bases fail Windows clippy::useless_vec. In
CI triage, log parsing leaves residual Buildkite bk;t= prefixes after
ANSI removal, misclassifies runner DNS, git-mirror, and Windows
modextwd file-lock flakes as code bugs, and --rebuild reruns
discard passing jobs.

Document module-qualified match constants, shared workspace parser
crates, HashMap over linear Vec scans, and Windows-clean
#[cfg(unix)] bases in the Rust rules and review prompt. Strip
residual bk;t= timestamp prefixes and classify runner DNS,
git-mirror, and modextwd cleanup flakes with Bazel-executed unit
tests in analyze-ci-failure, and prefer in-place job retries over
--rebuild in retry-ci-job.

In Rust crates, repeated string literals and duplicated format parsers
can drift, bare `match` identifiers silently bind on typos, and
`#[cfg(unix)]` `vec![...]` bases fail Windows `clippy::useless_vec`. In
CI triage, log parsing leaves residual Buildkite `bk;t=` prefixes after
ANSI removal, misclassifies runner DNS, git-mirror, and Windows
`modextwd` file-lock flakes as code bugs, and `--rebuild` reruns
discard passing jobs.

Document module-qualified `match` constants, shared workspace parser
crates, `HashMap` over linear `Vec` scans, and Windows-clean
`#[cfg(unix)]` bases in the Rust rules and review prompt. Strip
residual `bk;t=` timestamp prefixes and classify runner DNS,
git-mirror, and `modextwd` cleanup flakes with Bazel-executed unit
tests in `analyze-ci-failure`, and prefer in-place job retries over
`--rebuild` in `retry-ci-job`.
@rickeylev

Copy link
Copy Markdown
Collaborator Author

This pull request was prepared with AI assistance. Review comments on this PR
will be handled directly by @rickeylev, or reviewed and approved by @rickeylev
before any agent-assisted response or follow-up change is posted.

This is an automatically generated agent comment.

@rickeylev
rickeylev merged commit ca1e25d into bazel-contrib:main Nov 14, 2026
12 of 14 checks passed
@rickeylev
rickeylev deleted the agents_rust_and_ci_learnings branch November 14, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant