Repository navigation
tests: restore MODULE.bazel.lock after bzlmod_lockfile_test failure - #4503
Merged
rickeylev merged 1 commit intoNov 14, 2026
Merged
Conversation
`bzlmod_lockfile_test` runs with `no-sandbox` and invokes `bazel mod deps --lockfile_mode=update` in place when `bazel test //...` fails. Leaving `MODULE.bazel.lock` modified on disk lets `--flaky_test_attempts` retries pass on CI, masking stale lockfile failures, and dirties the local working tree. Wrap the lockfile update in a context manager that restores the original bytes and `mtime` on exit after reading the updated contents for diff and undeclared-output reporting, and add unit tests covering retry failure and restoration.
Collaborator
Author
|
This pull request was authored with AI agent assistance. An agent monitors CI This is an automatically generated agent comment. |
rickeylev
enabled auto-merge
November 14, 2026 17:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bzlmod_lockfile_testruns withno-sandboxand invokesbazel mod deps --lockfile_mode=updatein place whenbazel test //...fails. LeavingMODULE.bazel.lockmodified on disklets
--flaky_test_attemptsretries pass on CI, masking stale lockfilefailures, and dirties the local working tree.
Wrap the lockfile update in a context manager that restores the
original bytes and
mtimeon exit after reading the updated contentsfor diff and undeclared-output reporting, and add unit tests covering
retry failure and restoration.