Repository navigation
agents: refine PR, Rust, and code-style rules and review prompts - #4505
Merged
rickeylev merged 2 commits intoNov 14, 2026
Merged
Conversation
Capture review and porting lessons so agent replies, Rust ports, and benchmark summaries avoid recurring mistakes. Update `.agents/rules/` to apply `arXiv:2610.29162v1` readability constraints and leave review threads unresolved in PR replies, format benchmark summaries as short bullet lists, split idiomatic Rust guidance (`str::lines()`, `fs::create_dir_all`, `zlib-rs`, and `# Errors` docs), and require test and invariant-comment parity checks during code ports.
`pr.md` had a narrow `model_decision` description, dropped the `502 Bad Gateway` batching rationale, and contradicted `review-code/SKILL.md` on thread resolution. Standalone `flate2` in `rust.md` also needed explicit `zlib-rs`, and `review-code` prompts lacked the new rule checks. Broaden `pr.md` frontmatter, align `review-code` prompts and `SKILL.md` with `pr.md`, `rust.md`, and `code-style.md`, specify `flate2` `["zlib-rs", "runtime_detection"]` with `default-features = false` on both crates, and tighten passive phrasing.
Collaborator
Author
|
AI disclosure: An AI agent assisted with authoring this PR and helps monitor CI This is an automatically generated agent comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-resolving inline review threads closed discussions before
reviewers verified fixes, and review replies and benchmark summaries
lacked conciseness rules. Meanwhile,
rust.mdmodeled redundantempty-parent checks before
fs::create_dir_alland omittedzlib-rsDEFLATE and
# Errorsdoc guidance, code ports lacked a parity checkagainst original tests and invariant comments, and
review-codeprompts lagged behind those checks.
Update the PR, Rust, and code-style rules alongside the
review-codeskill and sub-agent prompts to keep review threads open by default,
apply
arXiv:2610.29162v1reply style and bulleted benchmarksummaries, specify pure-Rust
zlib-rsfeatures and idiomatic Rust andrustdoc conventions, and check test and comment parity during ports.