Skip to content

agents: refine PR, Rust, and code-style rules and review prompts - #4505

Merged
rickeylev merged 2 commits into
bazel-contrib:mainfrom
rickeylev:agents_pr_rust_code_style_rules
Nov 14, 2026
Merged

rickeylev merged 2 commits into
bazel-contrib:mainfrom
rickeylev:agents_pr_rust_code_style_rules

Conversation

@rickeylev

Copy link
Copy Markdown
Collaborator

Auto-resolving inline review threads closed discussions before
reviewers verified fixes, and review replies and benchmark summaries
lacked conciseness rules. Meanwhile, rust.md modeled redundant
empty-parent checks before fs::create_dir_all and omitted zlib-rs
DEFLATE and # Errors doc guidance, code ports lacked a parity check
against original tests and invariant comments, and review-code
prompts lagged behind those checks.

Update the PR, Rust, and code-style rules alongside the review-code
skill and sub-agent prompts to keep review threads open by default,
apply arXiv:2610.29162v1 reply style and bulleted benchmark
summaries, specify pure-Rust zlib-rs features and idiomatic Rust and
rustdoc conventions, and check test and comment parity during ports.

Capture review and porting lessons so agent replies, Rust ports, and
benchmark summaries avoid recurring mistakes.

Update `.agents/rules/` to apply `arXiv:2610.29162v1` readability
constraints and leave review threads unresolved in PR replies, format
benchmark summaries as short bullet lists, split idiomatic Rust
guidance (`str::lines()`, `fs::create_dir_all`, `zlib-rs`, and
`# Errors` docs), and require test and invariant-comment parity checks
during code ports.
`pr.md` had a narrow `model_decision` description, dropped the `502 Bad
Gateway` batching rationale, and contradicted `review-code/SKILL.md` on
thread resolution. Standalone `flate2` in `rust.md` also needed explicit
`zlib-rs`, and `review-code` prompts lacked the new rule checks.

Broaden `pr.md` frontmatter, align `review-code` prompts and `SKILL.md`
with `pr.md`, `rust.md`, and `code-style.md`, specify `flate2`
`["zlib-rs", "runtime_detection"]` with `default-features = false` on
both crates, and tighten passive phrasing.
@rickeylev

Copy link
Copy Markdown
Collaborator Author

AI disclosure: An AI agent assisted with authoring this PR and helps monitor CI
and review activity. @rickeylev reviews maintainer feedback and oversees code
updates and responses, or replies directly. Any comment posted by the agent
includes an explicit trailing disclosure line.

This is an automatically generated agent comment.

@rickeylev
rickeylev merged commit 47f83fa into bazel-contrib:main Nov 14, 2026
12 of 14 checks passed
@rickeylev
rickeylev deleted the agents_pr_rust_code_style_rules branch November 15, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant