Feat(plugin): Add set camera focus as ui-command (v0.1.x) - #297
Open
imdt-claudiop wants to merge 2 commits into
Open
imdt-claudiop wants to merge 2 commits into
imdt-claudiop wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
setCameraFocusto the camera UI commands so plugins can focus or clear a camera by user ID or stream ID:src/ui-commands/camera/types.ts:webcamSelectorunion (ByUserId/ByStreamId),SetCameraFocusCommandArguments, and thesetCameraFocusmethod onUiCommandsCameraObjectsrc/ui-commands/camera/enums.ts:SET_CAMERA_FOCUS_COMMANDsrc/ui-commands/camera/commands.ts: typed dispatcher for the commandtests/unit/ui-commands/camera/commands.test.ts: unit coverage for theuserIdselector,streamIdselector, andfocus: falsepayloads (asserting the enum and exact CustomEvent detail)README.md: documents the command and its typed usageThis is the same API proposed in #168, carried onto the current
v0.1.xline (0.1.26) so 4.0 clients can consume it - #168's branch is 181 commits behindv0.0.xand does not build against the current plugin engine. The client-side listener ships in a siblingbigbluebuttonPR pinned to this branch's commit.Validation
npm run test:unit(34 tests, including the new camera command suite)npm run lint,npm run buildConsumers on the 3.0 line: the equivalent
v0.0.xcarry is available as branchclaudio/camera-focus-v0.0.xon the same fork.