Repository navigation
chore: set propert type in noSwap - #4112
Open
imaliouris wants to merge 1 commit into
Open
imaliouris wants to merge 1 commit into
imaliouris wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
htmx 4's docs show
htmx.config.noSwap = [204, 304, '4xx', '5xx']as the way to restore htmx 2.x error-swapping behavior (see the migration guide and "What's New in htmx 4"). In a TypeScript project this assignment produces a type error, because the shipped type definitions don't match htmx 4's config.This PR updates the type definitions so that:
htmx.config.noSwapis typed as(number | string)[], so status codes and wildcard patterns like'4xx'and'5xx'are acceptedExample that previously failed to type-check and now compiles:
Testing
tsc --noEmitagainst a small TypeScript file containing the snippet above. It errored before this change and passes after.htmx.config.noSwap = [204, 304]still type-check.Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded