Repository navigation
Show the first new element for outerHTML swaps that start with whitespace - #4119
Open
cestercian wants to merge 1 commit into
Open
cestercian wants to merge 1 commit into
cestercian wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With
hx-swap="outerHTML show:top"(orshow:bottom), the swap target after an outerHTML swap is the first node of the new content. When the response starts with whitespace, that node is a text node, which has noscrollIntoView, so nothing scrolls.This picks the first element of the new content instead, falling back to the first node (or the parent) like before when there isn't one. This is what was suggested in the issue.
Corresponding issue: Fixes #4114
Testing
Added two tests in
test/tests/attributes/hx-swap.jsforouterHTML show:topandshow:bottomwith a response that starts with whitespace. Both fail without the change.npm testpasses locally in Chromium (1782 passed, 4 skipped).Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded