Skip to content

fix(chain,core): backport serde no-std fix to 0.23.x - #2466

Open
EliteCoder18 wants to merge 1 commit into
bitcoindevkit:release/chain-0.23.xfrom
EliteCoder18:backport/serde-no-std-chain-0.23.x
Open

EliteCoder18 wants to merge 1 commit into
bitcoindevkit:release/chain-0.23.xfrom
EliteCoder18:backport/serde-no-std-chain-0.23.x

Conversation

@EliteCoder18

Copy link
Copy Markdown
Contributor

Backport of #2227 (0790f04).

Description

Backport of #2227 (0790f0400b108974b538e44d6498dc6fe1157548) to release/chain-0.23.x, for bitcoindevkit/bdk_wallet#494.

Disable Serde’s default features in bdk_core and bdk_chain so enabling serde in a no_std build no longer pulls in serde/std through these crates. Keep alloc and rc in bdk_chain for changesets that contain Arc<Transaction>.

Notes to the reviewers

Verified the wallet’s thumbv7m-none-eabi build with both RBMT lockfiles using local copies of this patch and the Miniscript 12.x backport.

Changelog notice

  • Fix bdk_core and bdk_chain enabling serde/std in no_std builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant