Repository navigation
ci: require contributor approval for pull requests - #2468
Closed
noahjoeris wants to merge 1 commit into
Closed
noahjoeris wants to merge 1 commit into
noahjoeris wants to merge 1 commit into
Conversation
Close pull requests from forks whose author is not approved, and let maintainers approve contributors by commenting `lgtm` on an issue or pull request. Approved logins are stored in `APPROVED_CONTRIBUTORS` on the unprotected `approved-contributors` branch, so approvals don't need a pull request to master. Based on the workflows used by earendil-works/pi. See bitcoindevkit#2447.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2468 +/- ##
==========================================
+ Coverage 83.25% 83.62% +0.36%
==========================================
Files 31 31
Lines 6236 6339 +103
Branches 293 292 -1
==========================================
+ Hits 5192 5301 +109
+ Misses 976 970 -6
Partials 68 68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
As discussed on our call yesterday, we will first try to use the github native feature that limits Closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2447
Description
Adds the contributor approval gate discussed in #2447 to keep the review queue manageable. Issues remain open to everyone.
lgtmon its own line, or specific users withlgtm @user.Notes to the reviewers
Approvals live in
APPROVED_CONTRIBUTORSon a separateapproved-contributorsbranch, allowing workflow updates without bypassing master's protections. Neither workflow checks out or runs PR code.Tested end to end in a throwaway repository with a second account.
Before merging, create and seed the approval branch, then protect it against deletion and force pushes while allowing workflow commits. A missing allowlist causes the gate to fail, leaving PRs open.