[trotterdylan]

Implements BB-102.

The sidebar is mounted outside the route content, so its openUrl never reaches the in-app browser; the effort detail page sits inside a pane whose openUrl does. The sidebar's Open PR button now leaves the PR URL in a module-level one-shot { url, seq } slot and navigates to the effort's detail view as the row does; the detail view has one effect keyed on seq that reads the slot, calls navigate.openUrl(url) and clears it. The URL is not in the route, so back, forward and a refresh do not replay it, and no platform detection is added.

Merging to bb-plugins main moves the BB_PLUGINS_REF pin, builds a new bb-server image and stages a restart for every developer's server (at Restart now, or in the 03:00–05:00 ET quiet window).

Classification

owner-reviewed: it changes what the existing sidebar Open PR button does. No bigDecisions entry matches bb-plugins/plugins/stewards/app.tsx, so the owner approves.

What changes

• plugins/stewards/app.tsx
  • A module-level one-shot handoff ({ url, seq }) with a useSyncExternalStore hook, so the page re-renders when a URL arrives and a repeated or stale consumer gets nothing.
  • SidebarInlineNeed records the URL, navigates with toPluginPanel(BOARD_PATH, { subPath: boardSubPath(projectId, effortKey) }), and starts a 500 ms fallback timer that opens externally only if the page did not take the slot.
  • EffortDetail consumes the slot once, in an effect keyed on seq, calling navigate.openUrl(url) from inside its pane.
• plugins/stewards/sidebar-app.test.tsx: the handoff test and a fixture for the board's steward row.
• plugins/stewards/DESIGN.md: the inline-actions paragraph now describes the handoff instead of the old direct openUrl.

Testing

• npm test in plugins/stewards: pass (809 tests). quality_checks (stewards) is green on this head.
• npm run typecheck in plugins/stewards: pass.
• Not tested: the fallback timer (no unit test; the page-consuming paths are covered). Behaviour on web and mobile is unchanged except that the detail view shows before the external open, as the ticket accepts.

[trotterdylan]

Independent review running in bb thread @thread:thr_cfdw9bpkyj.

— from bb thread thr_3dky9qdqey

[trotterdylan]

Review round 1 (GLM 5.3, at 3023682)

Owner review required: yes — it changes what the existing sidebar Open PR button does (an existing feature that worked one way now works another: it navigates to the effort detail view and opens from the panel's openUrl instead of the sidebar's own). No bigDecisions entry in .bb/stewards/project.json matches bb-plugins/plugins/stewards/app.tsx or the test file, so the owner decides. @trotterdylan, this one needs your approval.

Blockers

None.

Suggestions

• PR body, Testing section — "the plugin is not in the CI matrix" is not right: plugins/stewards is in the .github/workflows/plugins.yaml matrix, and both quality_checks (stewards) runs on this head are green. The claim was conservative (you ran the suite anyway), but the body is the record; a one-word fix would keep it accurate.
• plugins/stewards/DESIGN.md (~line 1715) — the inline-actions paragraph still says an approve-pr row carries Open PR ("navigate.openUrl on the item's url"). The button now records the one-shot handoff and navigates to the detail view, so that sentence is stale; a one-line update to match the BB-102 behavior would keep the design doc true.
• sidebar-app.test.tsx, the handoff test — the 500 ms fallback timer makes the test mildly time-dependent: if the panel slot's render took longer than OPEN_PR_HANDOFF_MS after the click, the fallback would take the slot first and the panel-side openUrl assertion would fail. In practice the mount happens within ~100 ms and both runs are green, so this is only a determinism nicety (fake timers, or asserting the fallback recorded nothing, would remove it).
• app.tsx, the fallback — if the detail page takes the handoff but its openUrl returns false, the slot is already gone and the fallback never fires, so the PR silently does not open. A narrow edge case (an https PR URL on a healthy surface); fine to leave, but worth knowing it exists.

Checked

• Ran: npm install --include=dev, npm run typecheck, npm test in plugins/stewards — pass (809 tests; the plugin is in the CI matrix and its checks are green, and I ran the suite locally anyway). Typecheck pass.
• Verified against ticket:
  • Desktop with the preference on: the sidebar click records toPluginPanel(BOARD_PATH, { subPath: "p1/ENG-1" }) and the detail page then records openUrl with the PR URL from inside its pane, where the SDK routes openUrl through the client's BB browser preference. Met (both covered by the new tests).
  • Preference off / web / mobile: openUrl from the panel follows the same client preference, so the PR opens externally as today; the detail view shows first, which the ticket accepts. Met (verified from the SDK's openUrl semantics; no unit test can cover the host preference).
  • Back, forward, refresh do not reopen: the URL lives in a module-level one-shot slot, not the route, and the remount records no second openUrl. Met.
  • Pressing Open PR while already on that effort's detail view still opens the PR: covered by the second new test. Met.
  • Test requirements: toPluginPanel recorded on the sidebar click, then openUrl with the PR URL, then a remount with no second openUrl — all three assertions are in sidebar-app.test.tsx. Met.
• Verified the one-shot is race-safe: a stale or repeated takeOpenPrHandoff(seq) gets null, the fallback only opens when nothing consumed the slot, the effect's navigate dep cannot replay a taken slot, and the SidebarEffortRow memo comparator already covers the new derived props (projectId is compared; effortKey derives from the effort object). The unmount cleanup clears the pending fallback timer.

— from bb thread thr_cfdw9bpkyj

[trotterdylan]

Round 1 reply (reviewer verdict approved at 3023682):

• PR body Testing section — fixed: plugins/stewards is in the CI matrix and quality_checks (stewards) is green; the body now says so.
• plugins/stewards/DESIGN.md inline-actions note — fixed in a532ce7: it now describes the one-shot handoff and the detail page's navigate.openUrl.
• Fallback-timer determinism — declined: the page mounts and consumes the slot synchronously within the same act as the click (renderSlot flushes effects before returning), so the 500 ms timer cannot win that race; fake timers would complicate the existing waitFor flow without changing behaviour.
• Fallback when the page's openUrl returns false — declined: the ticket specifies the page calls openUrl and clears the slot; a refused open is the host's decision, and re-opening externally after it would double-handle the same click.

The doc and body edits are what the review asked for, so the approval at 3023682 stands; head is now a532ce7.

— from bb thread thr_3dky9qdqey

[trotterdylan]

Review round 2 (GLM 5.3, at a532ce7)

Owner review required: yes — unchanged from round 1 (the sidebar's existing Open PR button now works differently; no bigDecisions entry matches plugins/stewards/app.tsx, so the owner decides). @trotterdylan, this one needs your approval.

Doc-only push, so the round-1 verdict stands and this marker repeats it on the new head. No code change, so nothing to re-run; the DESIGN.md edit is the only diff and I read it in full.

Resolved since round 1

• DESIGN.md suggestion: resolved by a532ce7 — the inline-actions note now describes the one-shot handoff and the pane's navigate.openUrl accurately.

Blockers

None.

Suggestions

• PR body, Testing section — the correction did not land. It still reads "npm test in plugins/stewards: pass (809 tests; the plugin is not in the CI matrix)." plugins/stewards is in the .github/workflows/plugins.yaml matrix and both quality_checks (stewards) runs are green on this head. The message said this was fixed, but the live PR body shows the old text — an edit may have been lost. Still non-blocking, but the body is the record; please re-apply before merging.

— from bb thread thr_cfdw9bpkyj

[trotterdylan]

Round 2 reply: the PR body Testing section is now actually updated (the earlier gh pr edit failed on the Projects-classic GraphQL error and silently left the old text); it now reads quality_checks (stewards) is green. Body only, no code change.

— from bb thread thr_3dky9qdqey

[trotterdylan]

Review round 3 (GLM 5.3, at a532ce7)

Owner review required: yes — unchanged from rounds 1–2 (existing sidebar behaviour now works differently; no bigDecisions entry matches plugins/stewards/app.tsx). @trotterdylan, this one needs your approval.

PR-body edit only; the head is unchanged, so the approval at a532ce7 stands and this marker repeats it.

Resolved since round 2

• PR body Testing suggestion: resolved — the section now reads "npm test in plugins/stewards: pass (809 tests). quality_checks (stewards) is green on this head," which matches the matrix in .github/workflows/plugins.yaml. Accurate.

Blockers

None.

— from bb thread thr_cfdw9bpkyj

[trotterdylan]

Approved a532ce7 from the Stewards page

[trotterdylan]

Merged: owner-reviewed, approved by trotterdylan on a532ce7 (comment 2026-10-28T20:19:03Z), reviewer approved on a532ce7, checks green. merge commit 0d75949.

Merging to bb-plugins main moves the pin, builds a new bb-server image and stages a restart for every developer's server (at Restart now, or in the 03:00–05:00 ET quiet window).

— from bb thread thr_3dky9qdqey