Repository navigation
Do not export TrustCertificateActivity - #132
Open
ArnyminerZ wants to merge 1 commit into
Open
ArnyminerZ wants to merge 1 commit into
ArnyminerZ wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The targeted manifest change blocks unauthorized external launches while preserving internal activity and notification flows.
No open issues 🎉
What changed in this PR
This PR restricts access to the library’s certificate-trust activity, preventing other apps from launching it directly to trust certificates without user approval.
Changes:
- Sets
TrustCertificateActivitytoandroid:exported="false"while preserving internal invocation paths.
| File | Description |
|---|---|
lib/src/main/AndroidManifest.xml |
Disables external launches of TrustCertificateActivity. |
Review effort: Balanced
cketti
approved these changes
Oct 23, 2026
Member
Author
|
Tests are broken for cert4android (they run forever). We should probably fix them in a different PR before merging this one. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a security issue.
With
exportedset totrue, it allows any random app to automatically trust certificates as if the user had trusted them.