Fix: approve dependency build scripts so the project runs out of the box - #1
Closed
bitoiu wants to merge 1 commit into
Closed
Fix: approve dependency build scripts so the project runs out of the box#1bitoiu wants to merge 1 commit into
bitoiu wants to merge 1 commit into
Conversation
`pnpm run dev` runs `node src/main.ts dev`, and the @livekit/agents CLI performs a dependency-status check that shells out to `pnpm install`. Since pnpm 10.16, `pnpm install` exits non-zero (ERR_PNPM_IGNORED_BUILDS) when a dependency has an unapproved build script. This template has three (`@livekit/local-inference`, `protobufjs`, `sharp`), so on any recent pnpm a fresh clone fails at `pnpm run dev` before the agent starts. CI pins pnpm 10.15.0, which predates this behavior, so the failure is not caught there but affects every user on pnpm 10.16+ / 11. Approve the three build scripts in a tracked pnpm-workspace.yaml (the `pnpm` field in package.json is no longer read by pnpm 11), so the project installs and runs out of the box.
Owner
Author
|
Superseded by livekit-examples#58 (targeting the upstream repo). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A fresh clone fails at,
pnpm run dev, on any recentpnpm. Not super experienced withpnpmcompared tonpmso did some analysis on it.In our example that's:
@livekit/local-inferenceprotobufjssharpSo on pnpm 10.16+ / 11, that deps check exits 1 and
pnpm run devaborts before the agent ever starts.Suggested Fix (AI Assisted)
Add a tracked
pnpm-workspace.yamlthat approves the three build scripts:These values don't all need to be true from my understanding but they need to be declared true or false.
Feel free to close if there's a better solution.