feat(reachability): add the pure kubo config transform by Rinse12 · Pull Request #202 · bitsocialnet/bitsocial-cli

Rinse12 · 2026-11-02T12:57:04Z

Part of #198 (step 2).

Summary

The settled signature is unchanged. planKuboConfig sits beside it and also returns an edit record for reachability/config.json. A pure function can't otherwise tell our entries from identical operator ones, or know which old address to drop after an IP change.

planKuboConfig(kubo, { wsPort, announce, kuboEdits }, enabled)
  undo previous kuboEdits (back to the operator's baseline)
  if disabled: restore AutoTLS, return { kubo, kuboEdits: undefined }
  Addresses.Swarm          += /ip4/127.0.0.1/tcp/<wsPort>/ws, udp/443 quic-v1 and webtransport (v4, v6)
  Addresses.AppendAnnounce += announce
  Swarm.AddrFilters        -= /ip4/127.0.0.0/ipcidr/8
  AutoTLS.Enabled           = false (once per enable)
  return { kubo, kuboEdits }

computeKuboConfig(kubo, reachability, enabled) = planKuboConfig(...).kuboConfig

Behaviour the issue left open:

If the operator flips AutoTLS back on while enabled, repairs and IP changes keep it on, and disable leaves it on.
Anything the operator added while enabled survives disable.
A loopback filter the operator puts back is removed again on the next apply, because it would block the terminator.

Evidence

Before: the module did not exist. An early version failed the property test on a config listing the loopback filter twice: one copy was lost on restore. Fixed before this PR.
After: test/reachability/kubo-config.test.ts, 80+ tests, all passing.

for each of 17 config shapes (server profile, null lists, absent sections, operator duplicates, ...):
  bytes(disable(enable(x))) == bytes(x)
  bytes(enable(disable(enable(x)))) == bytes(enable(x))
  bytes(disable(enable(enable(x, new IP and ws port)))) == bytes(x)
  same round trip with the record reloaded through JSON

Merge Danger

Door: two-way

Blast Radius: none

New pure module with no callers yet.

computeKuboConfig(kuboConfig, reachabilityConfig, enabled) is the one place that decides the kubo edits. planKuboConfig also returns a record of what changed, which tells our entries from identical operator ones and lets disable restore the touched fields byte for byte.

coderabbitai · 2026-11-02T12:57:14Z

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 43 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 575d9247-ade9-43ce-8c7c-57751c25ad26

Commits

Reviewing files that changed from the base of the PR and between 6121b54 and 6ed4c24.

Files selected for processing: 2

src/reachability/kubo-config.ts
test/reachability/kubo-config.test.ts

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

chatgpt-codex-connector · 2026-11-02T12:57:17Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-02T13:00:22.018368Z	`1555fef`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1555fefe21

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-11-02T13:00:18Z

+    if (config.AutoTLS?.Enabled !== false) return;
+    if (autoTls.enabledShape === "absent") delete config.AutoTLS.Enabled;
+    else config.AutoTLS.Enabled = autoTls.enabled;
+    if (autoTls.sectionShape === "absent" && Object.keys(config.AutoTLS).length === 0) delete config.AutoTLS;


Restore top-level sections whose original shape was null

Restore the recorded "null" shape here as well as "absent". With a config containing "AutoTLS": null, enabling creates { "Enabled": false }, but disabling deletes Enabled and leaves AutoTLS: {}, violating the advertised byte-for-byte round trip. The analogous Addresses: null path at line 58 also returns {} instead of null.

Useful? React with 👍 / 👎.

claude · 2026-11-02T13:00:25Z

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Rinse12 · 2026-11-02T13:36:11Z

Consolidated into #208.

Rinse12 mentioned this pull request Nov 2, 2026

bitsocial reachability: make kubo browser-dialable (IP cert WSS via Caddy, UDP 443 WebTransport, UPnP) #198

Closed

chatgpt-codex-connector Bot reviewed Nov 2, 2026

View reviewed changes

Rinse12 mentioned this pull request Nov 2, 2026

feat(reachability): add versioned state and the status command #203

Closed

fix(reachability): restore null kubo sections on disable

6ed4c24

Rinse12 mentioned this pull request Nov 2, 2026

feat(reachability): make kubo dialable from browsers #208

Merged

Rinse12 closed this Nov 2, 2026

Navigation Menu

Repository navigation

feat(reachability): add the pure kubo config transform - #202

feat(reachability): add the pure kubo config transform#202
Rinse12 wants to merge 2 commits into
masterfrom
feat/reachability-kubo-config

Rinse12 commented Nov 2, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Nov 2, 2026 •

edited

Loading

Review limit reached

Uh oh!

chatgpt-codex-connector Bot commented Nov 2, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Nov 2, 2026

Uh oh!

claude Bot commented Nov 2, 2026

Uh oh!

Rinse12 commented Nov 2, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Rinse12 commented Nov 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Evidence

Merge Danger

Uh oh!

coderabbitai Bot commented Nov 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

chatgpt-codex-connector Bot commented Nov 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Nov 2, 2026

Choose a reason for hiding this comment

Uh oh!

claude Bot commented Nov 2, 2026

Code review

Uh oh!

Rinse12 commented Nov 2, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Rinse12 commented Nov 2, 2026 •

edited

Loading

coderabbitai Bot commented Nov 2, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Nov 2, 2026 •

edited

Loading