Repository navigation
chore(deps): upgrade @pkcprotocol/pkc-js to 0.0.134 - #218
Conversation
pkc-js 0.0.134 is one bug fix with no dependency, engine or DB version changes: reply pages are rebuilt exactly as they were signed, so a nested comment with an embedded page and a page-CID sort no longer fails signature validation and stalls the update cycle. Only the pkc-js entries in the lockfile change.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 20 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Closes #217
Summary
Upgrades
@pkcprotocol/pkc-jsfrom 0.0.133 to 0.0.134 (exact pin). No CLI code changes.The bug (pkcprotocol/pkc-js#477) needs
settings.pageswith a preloaded nested reply sort next to a non-preloaded one, plus a thread at least three levels deep. Communities on the default sorts never hit it. On affected communities, depths above the failure stop recalculating, and publications waiting on that cycle fail withERR_COMMENT_UPDATE_SIGNATURE_IS_INVALID.The same release also covers preloaded flat sorts. Reply rows now store a
flatmarker, and the post's signature vouches for flat page entries, because those entries were signed withrepliesthe page leaves out.Evidence
npm run build && npm run build:testpass.npm run test:cli: 52 files passed, 451 tests passed, 2 skipped.The CLI suite only shows the upgrade causes no regressions. The fix itself is covered by the tests added upstream (
rebuilt-replies-match-signed,rebuilt-replies-cycle).Merge Danger
Door: two-way
Reverting the pin restores 0.0.133. There is no
DB_VERSIONbump, but rows written by 0.0.134 can carry the newflatkey. Reading those rows after a downgrade was not tested.Blast Radius: pages
Limited to reply page generation and CommentUpdate verification in pkc-js. There are no API, dependency or
engineschanges, and only the pkc-js entries inpackage-lock.jsonchange.