Repository navigation
fix: scatter connect colours and the conda-feedstock tracking issue - #534
Conversation
…olour key With a varying z, a colour in connect_kwargs replaced the segments' z colouring, so they no longer read off the colorbar. The segments now keep the points' colormap and norm, and the colour is dropped with a UserWarning naming the key. Without a varying z, every spelling of the colour (color, c, colors, edgecolor, edgecolors, ec) sets the segments' colour; before, c raised AttributeError and the others were overridden by the points' colour. Two colour keys raise TypeError. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… commit The issue body was a plain string, so its version, checksum, commands and dependency comparison went out as literal placeholders; it is now built by build_issue_body as an f-string. The Git Commit line read the annotated tag object's ID; it now resolves the tag to the commit it names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… read Target tests, xfail(strict=True) until the script change lands: a 404 or a release listed before its sdist is retried with a bounded backoff, and the sdist SHA256 comes from PyPI's JSON API without downloading the file. The pre-release refusal already holds and guards. requests joins the test and dev extras because the tests import it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed wait Right after an upload, files.pythonhosted.org returned a cached 404 for the sdist, so the publish job's tracking issue failed until a manual retry. The script now reads the digest PyPI lists in its JSON API, retrying a 404, a release listed before its sdist, or a network error with a 15 s backoff that doubles to a 120 s cap, for at most 600 s. calculate_sha256 and its download are removed; validate_pypi_release shares the same retrying fetch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @blalterman's task in 20s —— View job Review of PR #534I read the diff for Verdict: No blocking issues. The changes follow the CLAUDE.md conventions: tests landed first as Scatter
|
…x-wait Target tests from the PR review, xfail(strict=True) until the script change lands. The version-mismatch check moves to its own test, since a shared fetch answers a second validation from the first response. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… CLI Validation and the checksum read now share one PyPI response, kept per version, so a run asks PyPI once and cannot wait twice. A null urls list counts as a release without its sdist. --max-wait sets the wait, so a local run on a mistyped version need not sit out ten minutes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @blalterman's task in 20s —— View job Review of PR #534I read the diff of Verdict: No blocking issues. The suggestions from the earlier review are already in this revision:
Scatter
|
Two fixes.
Scatter
connect=Truecolours (6d783539). With a varying z, a colour inconnect_kwargsreplaced the segments' z colouring, so they no longer matched the colorbar. The segments now keep the colormap, and the colour key is dropped with aUserWarningnaming it. Without a varying z, every spelling of the colour (color,c,colors,edgecolor,edgecolors,ec) now sets the segments' colour; before,craisedAttributeErrorand the others were overridden. Giving two raisesTypeError.Conda-feedstock tracking issue (
e60a3692,98fdb53d,44b5997c). The 0.5.0 publish job failed to open its tracking issue until a manual retry, because the sdist download from files.pythonhosted.org returned a cached 404 right after upload.requestsjoins thetestanddevextras, since the new tests import it.Tests landed first as
xfail(strict=True)in98fdb53d;44b5997cremoves the markers.Verification
--dry-runfor 0.5.0 against live PyPI: SHA256e42ced…41da(matches the feedstock recipe), commit7a4a2e48, full issue body.tmp_path. It clears everyGIT_*variable first: an earlier version, run by the pre-commit hook from a linked worktree, inheritedGIT_DIRand re-initialised the real repository as bare. That was reproduced in a throwaway repo, and the patched test was run inside the same linked-worktree hook without touching it.🤖 Generated with Claude Code