Repository navigation
ci: run the Windows suite only on PRs that change code - #536
Merged
Merged
Conversation
Windows took about 5.5 minutes per PR against 3 to 4.7 for Linux. A new changes job diffs the PR against its base; test-windows runs only when a changed file is not documentation (docs/, paper/, .claude/, *.md, *.rst, CITATION.cff, LICENSE), and no longer runs on feature-branch pushes. ci-summary accepts a skipped Windows job unless change detection failed. The release matrix still tests Windows on every version tag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @blalterman's task in 17s —— View job Review of PR #536The change is small and the logic holds up. I read the diff and the workflow triggers but did not run the workflow. I found no blocking issues. What works
Points to consider
Tests and risks Verdict: Looks good to merge. Point 1 is the one thing I'd tighten if you want the filter stricter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows took about 5.5 minutes per PR against 3 to 4.7 for Linux. This runs the Windows suite only where it can catch something.
changesjob diffs the PR against its base.test-windowsruns only when a changed file is not documentation (docs/,paper/,.claude/,*.md,*.rst,CITATION.cff,LICENSE). An empty or unreadable diff runs Windows.test-windowsno longer runs onfeature/**branch pushes; it runs on pull requests.ci-summaryaccepts a skipped Windows job unless change detection itself failed.The filter was checked locally under bash on eight sample change sets (docs only, root docs, source, docs plus a test, a workflow, pyproject.toml, CITATION.cff plus LICENSE, an empty diff). This PR changes a workflow file, so it counts as code and Windows runs here; the docs-only skip first runs on the next docs PR.
🤖 Generated with Claude Code