fix(desktop): recover relay-closed subscriptions#2060
Merged
Conversation
Co-authored-by: npub1mprnacetjua2xx3p5eddmhxyk6wv929ymm5py8kd2xfxurxahspqqlgyta <d8473ee32b973aa31a21a65adddcc4b69cc2a8a4dee8121ecd51926e0cddbc02@sprout-oss.stage.blox.sqprod.co> Signed-off-by: npub1mprnacetjua2xx3p5eddmhxyk6wv929ymm5py8kd2xfxurxahspqqlgyta <d8473ee32b973aa31a21a65adddcc4b69cc2a8a4dee8121ecd51926e0cddbc02@sprout-oss.stage.blox.sqprod.co>
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLOSEDframes instead of leaving relay subscriptions recorded locally after the relay has terminated themRoot cause
Desktop's
RelayClienthandledEVENT,OK, andEOSE, but ignoredCLOSED. When the relay closed a channel-window live subscription, Desktop continued treating its local subscription entry as active. New replies persisted successfully, but their live echoes no longer reached the independent thread cache, so the UI only showed them after reload/history fetch.Validation
pnpm typecheckpnpm test(3,122 passed)pnpm check:file-sizespnpm buildpnpm exec playwright test tests/e2e/messaging.spec.ts --grep 'thread reply appears after relay closes'--no-verifyonly becauseorigin/mainadvanced twice during the hook's branch-skew guardSupersedes the closed/retracted cache workaround in #2057.