fix(desktop): onboarding defaults — API key field and model search#2081
Merged
Conversation
Follow-up to #2079, which restored the provider dropdown in the onboarding default-config step. Selecting a credential-backed provider (Anthropic/OpenAI) still gave no way to enter the API key: the field was gated behind showAdvancedFields, which onboarding sets to false. Show the API key field whenever the provider field is visible and the selected provider requires a secret, and remove the now-unused hideUnconfiguredCredentialProviders machinery left behind by #2079. Co-authored-by: Brain <21994759fc7a6fa6b965551d35cfd7897d262f2495467f2d78694ddcfa6a5c7e@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
The onboarding model list can run long (Databricks discovery returns dozens of models) and the custom dropdown from #2039 dropped the typeahead search the persona dialog combobox already has. Add an inline filter input to AgentDropdownSelect, enabled for the model field, matching the persona combobox behavior. Co-authored-by: Brain <21994759fc7a6fa6b965551d35cfd7897d262f2495467f2d78694ddcfa6a5c7e@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
wesbillman
changed the title
wesbillman
enabled auto-merge (squash)
July 18, 2026 18:36
kalvinnchau
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #2079, which restored the provider dropdown in the onboarding default-config step. Two gaps remained:
showAdvancedFields, which onboarding sets tofalse. A fresh user could pick a provider but finish onboarding with a non-working default.AgentDropdownSelect— long discovery lists (e.g. Databricks) had to be scrolled manually.What
PersonaProviderApiKeyFieldwhenever the provider field is visible and the selected provider requires a secret (previously also requiredshowAdvancedFields)hideUnconfiguredCredentialProvidersprop and its filter machinery left behind by fix(desktop): restore onboarding provider choices #2079AgentDropdownSelect, enabled for the model field, matching the persona dialog combobox behavior (feat(desktop): add typeahead search to persona model dropdown #1542)Testing
pnpm --dir desktop run typecheckpnpm --dir desktop exec biome checkon touched filespnpm exec playwright test --project=smoke tests/e2e/onboarding-agent-defaults.spec.ts— 31 passed