fix(desktop): show macOS Dock badge for ordinary channel unreads - #7480
Open
dbroadfoot wants to merge 1 commit into
Open
fix(desktop): show macOS Dock badge for ordinary channel unreads#7480dbroadfoot wants to merge 1 commit into
dbroadfoot wants to merge 1 commit into
Conversation
Ordinary unreads used a blank badgeLabel as a "dot", which does not render on the macOS Dock. Use a minimal badge count instead and request Badge notification authorization so Dock updates are allowed. Signed-off-by: David Broadfoot <david@contextualcode.com> Co-authored-by: Cursor <cursoragent@cursor.com>
🔐 Codex Security Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ordinary channel unreads used a blank Dock
badgeLabel("dot") that does not render on macOS, so the Dock icon never showed unread activity. This switches that path to a minimal badge count and requests Badge notification authorization so Dock updates are allowed. E2E still sees state"dot"; only the native Dock call changes.Test plan
just desktop-standalone(separate from production Buzz.app)