buzz-acp: report startup permission outcomes and capture returned state - #7487
Open
p4jrj4b9nh-lab wants to merge 1 commit into
Open
buzz-acp: report startup permission outcomes and capture returned state#7487p4jrj4b9nh-lab wants to merge 1 commit into
p4jrj4b9nh-lab wants to merge 1 commit into
Conversation
Signed-off-by: PB <256599840+p4jrj4b9nh-lab@users.noreply.github.com>
🔐 Codex Security Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buzz silently skips unsupported startup permission modes and captures session configuration before applying supported modes. For example, a
bypassPermissionsrequest can fail to match the adapter’s advertised IDs without an explicit skip result.This patch records requested and advertised IDs with an explicit startup outcome, then captures the adapter-returned configuration after a successful mode request. Missing returned fields stay unknown; effective mode is not inferred from the requested value. Unsupported modes still cause no mutation, and transport failures remain fatal.
Related: #3710, #3715 and #5322. This does not close those broader issues. See also Codex #21975 for the separate human-fallback proposal.
Scope and security
This is a reporting fix. It does not implement a narrow-operation grant, verify the provider’s final reviewer/sandbox/rule sources, or change mode mappings. The receipt explicitly marks provider policy as unverified;
applieddenotes adapter RPC acceptance. Unsupported IDs are never translated into broader-access modes.Source and validation
44316ff72f5f7de014c66b01cbf534298a70c249onmain.aa387aa08e561d2413749abea0884a723a80b6ba.0d5dc44dc82653b4d81a1c57d41a1b1cc24cb723.crates/buzz-acp/README.mdandcrates/buzz-acp/src/pool.rs.cargo test -p buzz-acp: 924 unit and 9 integration tests passed.cargo fmt -p buzz-acp -- --check,cargo clippy -p buzz-acp --all-targets -- -D warnings, and diff/applicability checks passed.BUZZ_ACP_LAZY_POOLandBUZZ_ACP_IDLE_POOL_SLEEPso default-config tests exercise defaults.just cipassed.Attribution
Implementation author: Portfolio Supervisor
<a14f1f84a157b4bedc2e0090a270d88fca5668111e1268663461def9df3ebdd8@agents.invalid>. This deliberately non-personal identifier derives from the verified agent identity and does not attribute implementation to a GitHub account. PB<256599840+p4jrj4b9nh-lab@users.noreply.github.com>is the submitting committer and sole DCO signatory, not the implementation author.Rollback and deployment
The patch is uninstalled. Rollback of a later deployment is to restore the previous binary or revert this reporting change. Startup reporting changes require a fresh affected adapter session. Installing this reporting fix does not authorize retrying rejected operations.